New issue
Advanced search Search tips

Issue 740836 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 740816



Sign in to add a comment

Files app: OPEN dropdown menu does not have background when focused in check-select mode.

Project Member Reported by fukino@chromium.org, Jul 11 2017

Issue description

What steps will reproduce the problem?
(1) Open Files app
(2) Select a file by clicking the circle icon. The toolbar will become white.
(3) Click the triangle button in OPEN dropdown menu (the dropdown menu will be shown when selecting a file which has multiple associated applications)

What is the expected result?
There is a visible effect which indicates that the OPEN menu is active.

What happens instead?
The OPEN menu has focus rectangle on blue toolbar, but it doesn't in white toolbar (check-select mode)

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 

Comment 1 by fukino@chromium.org, Jul 11 2017

Blocking: 740816
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27d2945c584403c55da1c1692c36568d5718f971

commit 27d2945c584403c55da1c1692c36568d5718f971
Author: Naoki Fukino <fukino@chromium.org>
Date: Wed Jul 12 04:22:03 2017

Files app: Set custom style for activated buttons on white toolbar.

The default ripple color for toolbar buttons is white, which is invisible on
white background.
We need to set custom style to make the ripple visible.

Bug:  740836 
Change-Id: I7dc62bef120d5a06e8f42247cc1e5c604c6fd4ff
Reviewed-on: https://chromium-review.googlesource.com/566981
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485857}
[modify] https://crrev.com/27d2945c584403c55da1c1692c36568d5718f971/ui/file_manager/file_manager/foreground/js/toolbar_controller.js
[modify] https://crrev.com/27d2945c584403c55da1c1692c36568d5718f971/ui/file_manager/file_manager/main.html

Comment 3 by fukino@chromium.org, Jul 12 2017

Status: Fixed (was: Assigned)
Cc: dhadd...@chromium.org
Status: Verified (was: Fixed)

Sign in to add a comment