[MD Bookmarks] Focus ring reappears when refocusing the bookmarks tab |
|||
Issue descriptionThe focus outline which is hidden by mouse click is restored when refocusing the tab or window. It should remember the state of the focus ring.
,
Jul 14 2017
,
Jul 18 2017
Tested on Mac OS 10.12.5 using Chrome Dev version M61 - 61.0.3159.5 as per the issue mentioned in the original comment. Please refer the screencast attached. Steps followed: 1. Added few bookmarks. 2. Navigated to Chrome://bookmarks. 3. Click on Menu button of any bookmark. A menu is displayed. 4. Add a new tab and navigate back to Bookmarks tab. 5. Dismiss the Menu. Observations: Selection of Bookmark and round focus on the Bookmark menu are seen. @calamity -- Could you please confirm whether the focus displayed is as expected or not, so that it would help us in triaging the issue further by adding TE-Verified labels. Thank you!
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/715b2a4381954f5b310b6abc49bb9fb734ba01f6 commit 715b2a4381954f5b310b6abc49bb9fb734ba01f6 Author: Christopher Lam <calamity@chromium.org> Date: Tue Jul 25 03:09:57 2017 [MD Bookmarks] Fix some focus ring bugs. This CL fixes an issue with the focus ring appearing on modifier key presses and makes the focus ring appear on up and down arrow on the list which was broken due to event retargeting shenanigans. Bug: 740834 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id75c17596fccfd066cc97bae3a73150146d4ba26 Reviewed-on: https://chromium-review.googlesource.com/580172 Reviewed-by: Tim Sergeant <tsergeant@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#489204} [modify] https://crrev.com/715b2a4381954f5b310b6abc49bb9fb734ba01f6/chrome/browser/resources/md_bookmarks/mouse_focus_behavior.js [modify] https://crrev.com/715b2a4381954f5b310b6abc49bb9fb734ba01f6/chrome/test/data/webui/md_bookmarks/app_test.js |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jul 14 2017