New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740830 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Page doesn't load and error message is displayed in print preview.

Reported by rp...@etouch.net, Jul 11 2017

Issue description

Version: 61.0.3153.0 4b9102f9588fb6cf639a6165fd4777658d5ade0d-refs/heads/master@{#485143}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://histograms/ and press 'Ctrl + P' to open print preview.
2. Now enter page no. '14' in 'Pages' text box and observe page
 
Actual: Page doesn't load and error message is displayed in print preview
Expected: Page should load properly in print preview.

This is regression issue, broken in ‘M 60’ and will soon update other info :
Good build:60.0.3090.0
Bad build: 60.0.3091.0
 
Actual_video.mp4
726 KB View Download
Expected_video.mp4
943 KB View Download

Comment 1 by rp...@etouch.net, Jul 11 2017

Labels: hasbisect
Owner: thestig@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow bisect info:
https://chromium.googlesource.com/chromium/src/+log/531ed20b52b93b78c30a73e37ccf968238c25d84..ecf6129947673f09e05b912c817a7148bf8bfddc?pretty=fuller&n=100

Suspecting : r469749 from Narrow bisect 

@thestig: Could you please help to reassign if your change is not the cause for this change.
Labels: ReleaseBlock-Stable
Adding Release Block-Stable for this issue.Please remove if not the case.

Thank You!
thestig@, can you please look into this?
Just to update the latest behavior,
Still able to reproduce the issue on Win-10 using latest canary #61.0.3159.0.

thestig@ - Gentle Ping...!!
Could you please have a look into the issue as it has been marked as a stable blocker.

Thanks...!!
This is related to  bug 731600 , so I'm looking at the two together.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34e22410141c1c4d3c7efe5ee821b09d837bf995

commit 34e22410141c1c4d3c7efe5ee821b09d837bf995
Author: Lei Zhang <thestig@chromium.org>
Date: Thu Jul 20 04:05:10 2017

Print Preview: Disable Generate Draft feature.

The attempt to restore this feature in r469749 did not quite do the job
and has several issues.

BUG= 731600 , 740830 , 746768 

Change-Id: I417611e32e6d3e1bb29c96f6e5de6eee39abc846
Reviewed-on: https://chromium-review.googlesource.com/577374
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488129}
[modify] https://crrev.com/34e22410141c1c4d3c7efe5ee821b09d837bf995/chrome/browser/resources/print_preview/preview_generator.js
[modify] https://crrev.com/34e22410141c1c4d3c7efe5ee821b09d837bf995/chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js

Status: Fixed (was: Assigned)
Will use  bug 731600  for M60 merge.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-60; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-60 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 21 2017

Labels: merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d02baa474b267c2b53ac85a6faa3279310163f30

commit d02baa474b267c2b53ac85a6faa3279310163f30
Author: Lei Zhang <thestig@chromium.org>
Date: Fri Jul 21 22:40:18 2017

M60: Print Preview: Disable Generate Draft feature.

The attempt to restore this feature in r469749 did not quite do the job
and has several issues.

This is not cherry-picked from the master branch because the related
test got rewritten.

BUG= 731600 , 740830 , 746768 

Cr-Original-Original-Commit-Position: refs/heads/master@{#488129}
Reviewed-on: https://chromium-review.googlesource.com/577374
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8c7ec7bb50c390ad6aef603885f41cb46f8d05e2
Reviewed-on: https://chromium-review.googlesource.com/581676
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#662}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/d02baa474b267c2b53ac85a6faa3279310163f30/chrome/browser/resources/print_preview/preview_generator.js
[modify] https://crrev.com/d02baa474b267c2b53ac85a6faa3279310163f30/chrome/test/data/webui/print_preview/print_preview.js

Sign in to add a comment