New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740826 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 740816



Sign in to add a comment

Files app: Order actions in last-access time.

Project Member Reported by fukino@chromium.org, Jul 11 2017

Issue description

At this moment, the order in OPEN dropdown menu is as follows.

1) The default action
2) Generic actions (sorted by label names)
3) Non-generic actions (sorted by label names)

We are going to change it as follows:

<<option 1>>

1) The default action
2) Generic actions (sorted by last-access time)
3) Non-generic actions (sorted by last-access time)

<<options 2>>
1) The default action
2) All other actions (sorted by last-access time)
 

Comment 1 by fukino@chromium.org, Jul 11 2017

weifangsun@, mcirimele@,
Which should we choose, option 1 or option 2?

Generic actions are actions which can be applied all types of files.
They can not be default actions.
For now, generic actions are listed before non-generic actions in OPEN dropdown menu.
When we change the sort order from label names to last-access time, should be mix generic actions and non-generic actions in the menu?

Comment 2 by fukino@chromium.org, Jul 11 2017

Summary: Files app: Order actions in last-access time. (was: Files app: Order actions in)
Just to confirm - I assume that whether generic or non-generic, these are all "Open" actions (vs. More actions)? Could you provide an example of generic vs. non-generic?

Assuming that these are all Open file actions, I don't think we need to differentiate between generic and non-generic, so I think we should go with Option 2.

Comment 4 by fukino@chromium.org, Jul 12 2017

Generic action is an action for all types of files.
Non-generic actions have supported file types (e.g. PDF viewer is supported only for *.pdf files), but generic actions can be applied for all files.

Examples are "ZIP selection", "Upload to Evernote", etc...
I assume the typical OPEN actions are not generic, so typical generic actions will fall into the share options menu.

In share options menu, it does not make much sense to differentiate between generic and non-generic, since they can not be default action anyway.
I agree that we should go with option 2.


Thanks for the explanation fukino@!

In the share options menu, I agree that we don't need to differentiate between generic/non-generic. However, per the discussion in the mocks, we had proposed differentiating Share actions from other actions. Not sure if this is technically possible (or it may be a larger effort to address post-M61).

Comment 6 by fukino@chromium.org, Jul 20 2017

Cc: yawano@chromium.org
Weifang,
Should the order synced among multiple devices?
No - I don't think is necessary. It can be order by last accessed on the current device.
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c9555ea5307829e8536f6cd03d8f7ef98e59446

commit 6c9555ea5307829e8536f6cd03d8f7ef98e59446
Author: Naoki Fukino <fukino@chromium.org>
Date: Fri Jul 28 06:00:04 2017

Files app: Sort actions by last-executed time.

The new TaskHistory object keeps track of the latest 100 task executions,
and keep the history in sync with the local storage.
When the history in local storage is changed by other Files app window,
it will be notified via events in chrome.storage and the context menu will
be updated immediately to reflect the order in last-executed time.

Bug:  740826 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ida6f5e939cd4154e5fce89920baf3f5bbbd473d3
Reviewed-on: https://chromium-review.googlesource.com/584652
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490293}
[modify] https://crrev.com/6c9555ea5307829e8536f6cd03d8f7ef98e59446/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp
[modify] https://crrev.com/6c9555ea5307829e8536f6cd03d8f7ef98e59446/ui/file_manager/file_manager/foreground/js/file_tasks.js
[modify] https://crrev.com/6c9555ea5307829e8536f6cd03d8f7ef98e59446/ui/file_manager/file_manager/foreground/js/main_scripts.js
[modify] https://crrev.com/6c9555ea5307829e8536f6cd03d8f7ef98e59446/ui/file_manager/file_manager/foreground/js/task_controller.js
[modify] https://crrev.com/6c9555ea5307829e8536f6cd03d8f7ef98e59446/ui/file_manager/file_manager/foreground/js/task_controller_unittest.html
[modify] https://crrev.com/6c9555ea5307829e8536f6cd03d8f7ef98e59446/ui/file_manager/file_manager/foreground/js/task_controller_unittest.js
[add] https://crrev.com/6c9555ea5307829e8536f6cd03d8f7ef98e59446/ui/file_manager/file_manager/foreground/js/task_history.js

Comment 9 by fukino@chromium.org, Jul 28 2017

Status: Fixed (was: Assigned)
Labels: Merge-Request-61
Project Member

Comment 11 by sheriffbot@chromium.org, Jul 29 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 1 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd22d6c8223e654e74a4f8f3b208734c5e308c38

commit dd22d6c8223e654e74a4f8f3b208734c5e308c38
Author: Naoki Fukino <fukino@chromium.org>
Date: Tue Aug 01 01:53:29 2017

Files app: Sort actions by last-executed time.

The new TaskHistory object keeps track of the latest 100 task executions,
and keep the history in sync with the local storage.
When the history in local storage is changed by other Files app window,
it will be notified via events in chrome.storage and the context menu will
be updated immediately to reflect the order in last-executed time.

TBR=fukino@chromium.org

(cherry picked from commit 6c9555ea5307829e8536f6cd03d8f7ef98e59446)

Bug:  740826 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ida6f5e939cd4154e5fce89920baf3f5bbbd473d3
Reviewed-on: https://chromium-review.googlesource.com/584652
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490293}
Reviewed-on: https://chromium-review.googlesource.com/595288
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#205}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/dd22d6c8223e654e74a4f8f3b208734c5e308c38/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp
[modify] https://crrev.com/dd22d6c8223e654e74a4f8f3b208734c5e308c38/ui/file_manager/file_manager/foreground/js/file_tasks.js
[modify] https://crrev.com/dd22d6c8223e654e74a4f8f3b208734c5e308c38/ui/file_manager/file_manager/foreground/js/main_scripts.js
[modify] https://crrev.com/dd22d6c8223e654e74a4f8f3b208734c5e308c38/ui/file_manager/file_manager/foreground/js/task_controller.js
[modify] https://crrev.com/dd22d6c8223e654e74a4f8f3b208734c5e308c38/ui/file_manager/file_manager/foreground/js/task_controller_unittest.html
[modify] https://crrev.com/dd22d6c8223e654e74a4f8f3b208734c5e308c38/ui/file_manager/file_manager/foreground/js/task_controller_unittest.js
[add] https://crrev.com/dd22d6c8223e654e74a4f8f3b208734c5e308c38/ui/file_manager/file_manager/foreground/js/task_history.js

Comment 13 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment