weifangsun@, mcirimele@,

Implementing this for M61 might be difficult.

We use a UI library to show the context menu, but the library does not support submenu.
That's why we use a popup dialog in existing "More actions..." menu.

Implementing a menu by ourselves to implement submenu should be doable, but will not fit in M61 timeframe.
Can I use the same popup dialog for "Open with..." menu?

The screenshot shows the existing popup dialog for "More actions...".

Deleted: Screenshot from 2017-07-11 15:32:02.png 202 KB

	Screenshot from 2017-07-11 15:32:02.png 202 KB View Download

Deleted: Screenshot from 2017-07-11 15:32:10.png 168 KB

	Screenshot from 2017-07-11 15:32:10.png 168 KB View Download

Thanks for the info fukino@!

I agree that we can be implement the mocked sub-menu on the follow to M61 if it doesn't fit in the timeframe as it's lower priority than the other updates for this feature.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30c697e244f5f84df962631c71333280d2c1b630

commit 30c697e244f5f84df962631c71333280d2c1b630
Author: Naoki Fukino <fukino@chromium.org>
Date: Thu Jul 20 11:13:49 2017

Files app: Add a string for context menu item label to choose OPEN_WITH actions.

Bug:  740821 
Change-Id: I4fa17745613ac2c25efe260673dc324cf5f6df3a
Reviewed-on: https://chromium-review.googlesource.com/579249
Reviewed-by: Yuki Awano <yawano@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488193}
[modify] https://crrev.com/30c697e244f5f84df962631c71333280d2c1b630/chrome/app/chromeos_strings.grdp

Hi weifangsun@, I have several questions on this feature.

We have "Share with others" option in context menu for Google Drive files. Should we move the option inside "More actions..." sub popup dialog?
I prefer keeping it in top-level menu item, since it won't be so clear that "More actions..." includes share menu for Drive files.(In toolbar menu, it should be OK since we use the share icon)

For the context menu, I think it's ok to keep the "Share with others" option at the top level (not sub-menu of More actions) as it is currently in a separate section with the "Available offline" top level action as well.

mcirimele@ - What do you think?

I agree. Let's keep "Share with others" a top level menu item in the context menu.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c47494fa5448761207b214d3223c916b793ff0a5

commit c47494fa5448761207b214d3223c916b793ff0a5
Author: Naoki Fukino <fukino@chromium.org>
Date: Wed Aug 02 08:31:01 2017

Files app: Add "Open with..." sub menu in the context menu.

In the context menu, we have "More actions..." menu item to open a task
picker dialog for all actions.
We are going to have separated following two menu items to organize them.
"Open with..."    <= Open a task picker for OPEN actions.
"More actions..." <= Open a task picker for any other actions.

Bug:  740821 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4e75c27ac32c2a6da23adfc787db9078662fa19f
Reviewed-on: https://chromium-review.googlesource.com/594759
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491311}
[modify] https://crrev.com/c47494fa5448761207b214d3223c916b793ff0a5/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/c47494fa5448761207b214d3223c916b793ff0a5/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/c47494fa5448761207b214d3223c916b793ff0a5/ui/file_manager/file_manager/foreground/js/file_tasks.js
[modify] https://crrev.com/c47494fa5448761207b214d3223c916b793ff0a5/ui/file_manager/file_manager/foreground/js/task_controller.js
[modify] https://crrev.com/c47494fa5448761207b214d3223c916b793ff0a5/ui/file_manager/file_manager/foreground/js/task_controller_unittest.html
[modify] https://crrev.com/c47494fa5448761207b214d3223c916b793ff0a5/ui/file_manager/file_manager/main.html

This bug requires manual review: There is .grd file changes and we are only 32 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

I'd like to merge the commit in Comment #10, which does not include .grd file change.

Approving merge to M61 Chrome OS.

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db0d76138b6b53b5d7e08839479c607517dbc404

commit db0d76138b6b53b5d7e08839479c607517dbc404
Author: Naoki Fukino <fukino@chromium.org>
Date: Thu Aug 10 03:37:01 2017

Files app: Add "Open with..." sub menu in the context menu.

In the context menu, we have "More actions..." menu item to open a task
picker dialog for all actions.
We are going to have separated following two menu items to organize them.
"Open with..."    <= Open a task picker for OPEN actions.
"More actions..." <= Open a task picker for any other actions.

TBR=fukino@chromium.org

(cherry picked from commit c47494fa5448761207b214d3223c916b793ff0a5)

Bug:  740821 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4e75c27ac32c2a6da23adfc787db9078662fa19f
Reviewed-on: https://chromium-review.googlesource.com/594759
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491311}
Reviewed-on: https://chromium-review.googlesource.com/609562
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#427}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/db0d76138b6b53b5d7e08839479c607517dbc404/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/db0d76138b6b53b5d7e08839479c607517dbc404/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/db0d76138b6b53b5d7e08839479c607517dbc404/ui/file_manager/file_manager/foreground/js/file_tasks.js
[modify] https://crrev.com/db0d76138b6b53b5d7e08839479c607517dbc404/ui/file_manager/file_manager/foreground/js/task_controller.js
[modify] https://crrev.com/db0d76138b6b53b5d7e08839479c607517dbc404/ui/file_manager/file_manager/foreground/js/task_controller_unittest.html
[modify] https://crrev.com/db0d76138b6b53b5d7e08839479c607517dbc404/ui/file_manager/file_manager/main.html