New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 740819 link

Starred by 1 user
Status: Verified
Owner:
fukino@chromium.org
Closed: Jul 2017
Cc:
weifangsun@chromium.org
mkarkada@chromium.org
█ mcirimele@chromium.org
dhadd...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 740816
issue 741553



Sign in to add a comment

Files app: Add a share menu in toolbar.

Project Member Reported by fukino@chromium.org, Jul 11 2017 
At this moment we have following types of actions in OPEN dropdown menu in toolbar.
- Open with
- Share with
- Add to
- Pack with

We are going to keep only "Open with" actions in OPEN dropdown menu, and move all other actions to "Share" menu.

Mock: go/filesapp-osi-mocks

Comment 1 by fukino@chromium.org, Jul 12 2017

Blocking: 741553
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef2e8483ccaeee5a1e185e4e8d4b4697588a838b

commit ef2e8483ccaeee5a1e185e4e8d4b4697588a838b
Author: Naoki Fukino <fukino@chromium.org>
Date: Thu Jul 13 08:10:41 2017

Files app: Add share options menu on toolbar.

This CL to divide tasks to open tasks and other tasks.
  open tasks: Files app internal tasks and file_hander tasks with OPEN_WITH verb.
  other tasks: all other tasks.

The OPEN combubutton should have only open tasks, and the new option menu should
have the other tasks. The new option menu has share icon as most of tasks should
be SHARE_WITH tasks, but other kind of tasks (e.g. PACK_WITH) can also be
included.

Existing share{_white}.png was renamed as person_add{_white}.png and the new
icon for share button was named as share{_white}.png, to be consistent with
the naming in go/icons.

Bug:  740819 
Change-Id: Ic5e82aed490af9372e300c5153b5a384b6656464
Reviewed-on: https://chromium-review.googlesource.com/567917
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486316}
[modify] https://crrev.com/ef2e8483ccaeee5a1e185e4e8d4b4697588a838b/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/ef2e8483ccaeee5a1e185e4e8d4b4697588a838b/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/ef2e8483ccaeee5a1e185e4e8d4b4697588a838b/ui/file_manager/file_manager/foreground/css/file_manager.css
[add] https://crrev.com/ef2e8483ccaeee5a1e185e4e8d4b4697588a838b/ui/file_manager/file_manager/foreground/images/files/ui/2x/person_add.png
[add] https://crrev.com/ef2e8483ccaeee5a1e185e4e8d4b4697588a838b/ui/file_manager/file_manager/foreground/images/files/ui/2x/person_add_white.png
[modify] https://crrev.com/ef2e8483ccaeee5a1e185e4e8d4b4697588a838b/ui/file_manager/file_manager/foreground/images/files/ui/2x/share.png
[modify] https://crrev.com/ef2e8483ccaeee5a1e185e4e8d4b4697588a838b/ui/file_manager/file_manager/foreground/images/files/ui/2x/share_white.png
[add] https://crrev.com/ef2e8483ccaeee5a1e185e4e8d4b4697588a838b/ui/file_manager/file_manager/foreground/images/files/ui/person_add.png
[add] https://crrev.com/ef2e8483ccaeee5a1e185e4e8d4b4697588a838b/ui/file_manager/file_manager/foreground/images/files/ui/person_add_white.png
[modify] https://crrev.com/ef2e8483ccaeee5a1e185e4e8d4b4697588a838b/ui/file_manager/file_manager/foreground/images/files/ui/share.png
[modify] https://crrev.com/ef2e8483ccaeee5a1e185e4e8d4b4697588a838b/ui/file_manager/file_manager/foreground/images/files/ui/share_white.png
[modify] https://crrev.com/ef2e8483ccaeee5a1e185e4e8d4b4697588a838b/ui/file_manager/file_manager/foreground/js/file_tasks.js
[modify] https://crrev.com/ef2e8483ccaeee5a1e185e4e8d4b4697588a838b/ui/file_manager/file_manager/foreground/js/task_controller.js
[modify] https://crrev.com/ef2e8483ccaeee5a1e185e4e8d4b4697588a838b/ui/file_manager/file_manager/foreground/js/task_controller_unittest.js
[modify] https://crrev.com/ef2e8483ccaeee5a1e185e4e8d4b4697588a838b/ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js
[modify] https://crrev.com/ef2e8483ccaeee5a1e185e4e8d4b4697588a838b/ui/file_manager/file_manager/main.html

Comment 3 by fukino@chromium.org, Jul 13 2017

Status: Fixed (was: Started)

Comment 4 by mkarkada@chromium.org, Jul 21 2017

Status: Verified (was: Fixed)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94654ec9140d4e618376ec0a9e339f817637a5db

commit 94654ec9140d4e618376ec0a9e339f817637a5db
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Fri Jul 21 01:53:01 2017

Change tooltip text of the share option menu button to "More actions".

The button has more than "share" options which doesn't fit in "OPEN".

Bug:  740819 
Change-Id: I52a04ab04b010823807bbbda7b49f8aa2b943f4a
Reviewed-on: https://chromium-review.googlesource.com/580589
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Satoru Takabayashi <satorux@chromium.org>
Commit-Queue: Satoru Takabayashi <satorux@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488544}
[modify] https://crrev.com/94654ec9140d4e618376ec0a9e339f817637a5db/chrome/app/chromeos_strings.grdp

Comment 6 by mkarkada@chromium.org, Jul 28 2017

Cc: dhadd...@chromium.org mkarkada@chromium.org
Status: Assigned (was: Verified)
Tooltip text of the share option menu is still not changed to "More actions".

Verified on M61 (Chrome os 9765.9.0, 61.0.3163.16 dev build)

Comment 7 by mkarkada@chromium.org, Jul 28 2017

Status: Fixed (was: Assigned)
This issue seems to be fixed on M62 (Chrome os 9784.0.0, 62.0.3166.0 dev build)

Comment 8 by mkarkada@chromium.org, Aug 2 2017

Status: Verified (was: Fixed)
Verified on M62 (Chrome OS 9801.0.0, 62.0.3174.0 dev build).
►

Sign in to add a comment