New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740817 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 740816



Sign in to add a comment

Files app: Rename the label "Share" to "Share with others" for sharing settings in Drive.

Project Member Reported by fukino@chromium.org, Jul 11 2017

Issue description

Label "Share" is used in:
- item label in context menu for Drive files.
- tooltip for share button in toolbar.

Making the label to "Share with others" to be consistent with the header title of sharing setting dialog.

This is from the discussion in go/filesapp-osi-mocks.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/358df94ebc08067e0005fbdf6f34f2fe79cd7513

commit 358df94ebc08067e0005fbdf6f34f2fe79cd7513
Author: Naoki Fukino <fukino@chromium.org>
Date: Tue Jul 11 10:15:15 2017

Files app: Rename the label to open sharing dialog for Google Drive files.

To be consistent with the dialog title and make it easier to distinguish it from
other share-related actions, we rename the label which is used in following
locations.
- Menu item label in context menu.
- Spoken feedback label for the toolbar button.
- Tooltip label for the toolbar button.
All of them uses the same dictionary entry.

Bug:  740817 
Change-Id: If6f893bbd2a4595b75e8694fa88b5283d3327af1
Reviewed-on: https://chromium-review.googlesource.com/566784
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485577}
[modify] https://crrev.com/358df94ebc08067e0005fbdf6f34f2fe79cd7513/chrome/app/chromeos_strings.grdp

Comment 2 by fukino@chromium.org, Jul 11 2017

Status: Fixed (was: Assigned)
Cc: dhadd...@chromium.org
Status: Assigned (was: Fixed)
 Issue 748181 , mentions this feature is inconsistent. Share with others options doesn't always appear. Checked on M62.

Comment 4 by fukino@chromium.org, Jul 25 2017

Status: Fixed (was: Assigned)
mkarkada@, could you keep this issue separated from  issue 748181  and verify the behaviors described in issue described? Thanks!
Cc: mkarkada@chromium.org
Status: Assigned (was: Fixed)
1) Label 'share' is fixed to 'Share Options' and use same dictionary  for
- Spoken feedback label for the toolbar button.
- Tooltip label for the toolbar button.

2) However, not for
- Menu item label in context menu.

context menu has 'Share with others' option which becomes redundant once  issue 748206  gets fixed.

Checked on 9765.5.0, 61.0.3163.11 dev build.

Comment 6 by fukino@chromium.org, Jul 26 2017

> 2) However, not for
> - Menu item label in context menu.

Sorry... I think I don't understand this part.
You saw "Share" instead of "Share with others" in context menu for Drive files?

Comment 7 by fukino@chromium.org, Jul 28 2017

Marking this as Fixed, assuming there is "Share with others" in the context menu.

mkarkada@, if you find wrong string in the context menu, please reopen this.
If you find another issue which is not same but related to this bug, please file a new issue. Thanks!

Comment 8 by fukino@chromium.org, Jul 28 2017

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Context menu has "Share with others" option. Thank you!

Sign in to add a comment