New issue
Advanced search Search tips

Issue 740811 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Color of files-toggle-ripple cannot be changed by CSS custom property

Project Member Reported by yamaguchi@chromium.org, Jul 11 2017

Issue description

<b>Chrome Version: <From about:version: Google Chrome x.x.x.x></b>
<b>Chrome OS Version: <From about:version: Platform x.x.x.x></b>
<b>Chrome OS Platform: <Make/model of computer running Chrome OS></b>
<b>Network info: <network, encryption type, router model (if known)></b>


https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/elements/files_toggle_ripple.js?sq=package:chromium&dr=CSs
The description states:
 * You can change ripple color by the following CSS variable.
 *
 * files-toggle-ripple#my-button {
 *   --files-toggle-ripple: {
 *     background-color: black;
 *   }
 * }

however, it seems not reflected to the toggle ripple effects.

Steps To Reproduce:
(1) Add this snippet to file_manager.css
files-toggle-ripple {
  --files-toggle-ripple: {
    background-color: black;
  };
  --files-toggle-ripple-activated: {
    background-color: black;
  };
}
(2) Click the gear menu in the Files app.
(3) See the ripple colors.

Expected Result:
The color of the ripple and toggle effects are black.

Actual Result:
The color of the ripple and toggle effects are white.

 
I am seeing the custom properties are inherited to the shadow elements but not reflected to the styles.
Screenshot 2017-07-11 14:56:04.png
219 KB View Download
Status: WontFix (was: Unconfirmed)
As noted in the document,
https://www.polymer-project.org/2.0/docs/devguide/custom-css-properties
- the custom properties must be written inside <style is="custom-style"> or in dom-module.
- call updateStyles method when need to apply custom properties after element creation.

Sign in to add a comment