New issue
Advanced search Search tips

Issue 740805 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Undo skia "dsb" hack

Project Member Reported by diand...@chromium.org, Jul 11 2017

Issue description

We believe that we have root caused the CPU errata and can now revert the "dsb" hack.

AKA, revert <https://skia-review.googlesource.com/c/14062/>

See  bug #711784  for details about the root cause.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 16 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/42102420c02a525f57264c124ef941882d22c5a1

commit 42102420c02a525f57264c124ef941882d22c5a1
Author: Mike Klein <mtklein@google.com>
Date: Sun Jul 16 20:24:07 2017

Revert "Inject a dsb into SkAnalyticEdge::setLine() to work around ARMv7 CPU erratum."

This reverts commit 101806f4526d0ba5d48515c82a28dbf6956aca4d.

Reason for revert: no more need.

BUG= chromium:740805 

Original change's description:
> Inject a dsb into SkAnalyticEdge::setLine() to work around ARMv7 CPU erratum.
> 
> BUG= chromium:710131 
> 
> Change-Id: I4568bc24cc8fabb6f9df3b7645b01a98e11791b8
> Reviewed-on: https://skia-review.googlesource.com/14062
> Reviewed-by: Doug Anderson <dianders@google.com>
> Commit-Queue: Mike Klein <mtklein@chromium.org>

TBR=mtklein@chromium.org,dianders@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  chromium:710131 
Change-Id: Ib5b58a951ae56e0f0523cfed27754e0cd150e6ce
Reviewed-on: https://skia-review.googlesource.com/23840
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>

[modify] https://crrev.com/42102420c02a525f57264c124ef941882d22c5a1/src/core/SkAnalyticEdge.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9a937ac93b4817a226b3f01526d6e10c7b63836

commit a9a937ac93b4817a226b3f01526d6e10c7b63836
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Sun Jul 16 21:50:22 2017

Roll src/third_party/skia/ 1fcd10aae..42102420c (1 commit)

https://skia.googlesource.com/skia.git/+log/1fcd10aae433..42102420c02a

$ git log 1fcd10aae..42102420c --date=short --no-merges --format='%ad %ae %s'
2017-07-16 mtklein Revert "Inject a dsb into SkAnalyticEdge::setLine() to work around ARMv7 CPU erratum."

Created with:
  roll-dep src/third_party/skia
BUG= 740805 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=caryclark@chromium.org

Change-Id: I6c7f21b7c92ae586ff56b9b97cc1a14fc0e09648
Reviewed-on: https://chromium-review.googlesource.com/573528
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487021}
[modify] https://crrev.com/a9a937ac93b4817a226b3f01526d6e10c7b63836/DEPS

Status: Fixed (was: Untriaged)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment