New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 740798 link

Starred by 2 users
Status: Verified
Owner:
█ thanhph@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Cc:
sadrul@chromium.org
█ bruthig@chromium.org
█ thanhph@chromium.org
█ tdander...@chromium.org
varkha@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Show the tooltip text for a View in UI devtools

Project Member Reported by sadrul@chromium.org, Jul 11 2017 
A views::View can have a tooltip [1]. We should show this for views (only for Views that do have tooltips) as a property. I think it will need to a readonly attribute though, because it doesn't look like we have an easy way to set the tooltip on a View.


[1] https://cs.chromium.org/chromium/src/ui/views/view.h?l=881

Comment 1 by tdander...@chromium.org, Jul 17 2017

Labels: -Hotlist-DevTools Hotlist-UI-DevTools

Comment 2 by thanhph@chromium.org, Aug 4 2017

Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e4f231c5bef6739a176247d86d4dc1487836ad2

commit 5e4f231c5bef6739a176247d86d4dc1487836ad2
Author: Thanh Pham <thanhph@chromium.org>
Date: Mon Aug 14 20:45:46 2017

Show the tooltip text for a View in UI devtools.

To quickly view tooltips for views::Views, UI Devtools should show
tooltips for view::Views as a read-only property when a node is
inspected. This cl also enable adding custom attributes specific for
Window, Widget or View elements.

Bug:  740798 
Change-Id: I2b4c75ff02566b03e948d7df50ec8a13733d21a3
Reviewed-on: https://chromium-review.googlesource.com/608868
Commit-Queue: Thanh Pham <thanhph@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494174}
[modify] https://crrev.com/5e4f231c5bef6739a176247d86d4dc1487836ad2/components/ui_devtools/views/ui_devtools_css_agent.cc
[modify] https://crrev.com/5e4f231c5bef6739a176247d86d4dc1487836ad2/components/ui_devtools/views/ui_devtools_unittest.cc
[modify] https://crrev.com/5e4f231c5bef6739a176247d86d4dc1487836ad2/components/ui_devtools/views/ui_element.h
[modify] https://crrev.com/5e4f231c5bef6739a176247d86d4dc1487836ad2/components/ui_devtools/views/view_element.cc
[modify] https://crrev.com/5e4f231c5bef6739a176247d86d4dc1487836ad2/components/ui_devtools/views/view_element.h
[modify] https://crrev.com/5e4f231c5bef6739a176247d86d4dc1487836ad2/components/ui_devtools/views/widget_element.cc
[modify] https://crrev.com/5e4f231c5bef6739a176247d86d4dc1487836ad2/components/ui_devtools/views/widget_element.h
[modify] https://crrev.com/5e4f231c5bef6739a176247d86d4dc1487836ad2/components/ui_devtools/views/window_element.cc
[modify] https://crrev.com/5e4f231c5bef6739a176247d86d4dc1487836ad2/components/ui_devtools/views/window_element.h

Comment 4 by thanhph@chromium.org, Aug 14 2017

Status: Fixed (was: Started)

Comment 5 by sadrul@chromium.org, Oct 22 2017

Owner: thanhph@chromium.org
Status: Verified (was: Fixed)
►

Sign in to add a comment