VideoFrame::AddDestructionObserver() [1] should be defined with a move-only OnceCallback argument. |
|||||
Issue descriptionVideoFrame::AddDestructionObserver() [1] should be defined with a move-only OnceCallback argument. Found this while trying to pass a mojo move-only callback as destruction observer (in [2,3]), but it makes sense: the destruction callback should be called only once, upon destruction, it doesn't make any sense if a VideoFrame gets destructed twice :-) [1] https://cs.chromium.org/chromium/src/media/base/video_frame.h?l=374 [2] https://chromium-review.googlesource.com/c/558846/ [3] https://bugs.chromium.org/p/chromium/issues/detail?id=736517
,
Jul 12 2017
+tzik@ FYI and since you seems to be doing similar work in https://bugs.chromium.org/p/chromium/issues/detail?id=714018
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd4a286c40bc98c1c2e9ee210fec484ee38eaf31 commit bd4a286c40bc98c1c2e9ee210fec484ee38eaf31 Author: tzik <tzik@chromium.org> Date: Thu Jul 13 02:21:56 2017 Use OnceCallback on VideoFrame::AddDestructionObserver Bug: 740794 Change-Id: I7e4de04dfd2230b1eef2d7e85d7874055122b6dd Reviewed-on: https://chromium-review.googlesource.com/567902 Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#486224} [modify] https://crrev.com/bd4a286c40bc98c1c2e9ee210fec484ee38eaf31/media/base/video_frame.cc [modify] https://crrev.com/bd4a286c40bc98c1c2e9ee210fec484ee38eaf31/media/base/video_frame.h
,
Jul 13 2017
,
Jul 13 2017
Should be fixed by #4.
,
Nov 7 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mcasas@chromium.org
, Jul 11 2017