New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740793 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit 15 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Tracking bug for Bling* no-op alerts

Project Member Reported by sczs@chromium.org, Jul 11 2017

Issue description

As we develop the new architecture, some actions/items/flows,etc. will be no-op since they are part of a working component, but its functionality hasn't been developed yet. 
(e.g. Some menu items. The Menu itself is working and it displays the items, but some of these items are not working yet).

In order to differentiate no-op actions from broken ones, we will display a simple alert for no-op actions, this way we'll know if something was/is broken, or if it still hasn't been implemented yet. 

 

Comment 1 by sczs@chromium.org, Jul 11 2017

Components: UI>Browser>Mobile
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a04b1bdf25c84db0beabed1c1d53efc8463df6f1

commit a04b1bdf25c84db0beabed1c1d53efc8463df6f1
Author: sczs <sczs@chromium.org>
Date: Tue Jul 18 18:22:41 2017

[ios clean] Display alert for no-op features.

As we develop the new architecture, some actions/items/flows,etc. will 
be no-op since they are part of a working component, but its functionality 
hasn't been developed yet. (e.g. Some menu items. The Menu itself is working 
and it displays the items, but some of these items are not working yet).

In order to differentiate no-op actions from broken ones, we will display a 
simple alert for no-op actions, this way we'll know if something was/is broken, 
or if it still hasn't been implemented yet. 

This CL implements these alerts for the NTP, Toolbar and ToolsMenu. 

Bug: 740793
Change-Id: I128a289403f3fb20342d451cd15699fbacade2e1
Reviewed-on: https://chromium-review.googlesource.com/570846
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487531}
[modify] https://crrev.com/a04b1bdf25c84db0beabed1c1d53efc8463df6f1/ios/clean/chrome/browser/ui/ntp/ntp_coordinator.mm
[modify] https://crrev.com/a04b1bdf25c84db0beabed1c1d53efc8463df6f1/ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm
[modify] https://crrev.com/a04b1bdf25c84db0beabed1c1d53efc8463df6f1/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm

Components: -UI>Browser>Mobile UI>Browser>Core

Sign in to add a comment