New issue
Advanced search Search tips

Issue 740786 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

chrome_public_test_apk failing on chromium.linux/Android Tests (dbg)

Project Member Reported by calamity@chromium.org, Jul 11 2017

Issue description

chrome_public_test_apk failing on chromium.linux/Android Tests (dbg)

Builders failed on: 
- Android Tests (dbg): 
  https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29


Bookmark tests timing out loading the bookmark model.
 
Labels: -Sheriff-Chromium
Cc: calamity@chromium.org
Components: UI>Browser>History Tests
Labels: Sheriff-Chromium
Owner: twelling...@chromium.org
Sheriff, any idea when these started failing?

Please cc or assign Android history bugs to me in the future to ensure they make it into my queue.

Labels: Pri-1 Type-Bug-Regression
Possibly related to issue 739581. Per that issue, I'm going to mark the entire suite as @RetryOnFailure for now since a culprit hasn't been identified; when I have extra cycles I'll investigate further. My best guess is that the junit 4 migration changed the startup path. 


junit.framework.AssertionFailedError: Bookmark model did not load: Timeout.
	at junit.framework.Assert.fail(Assert.java:50)
	at org.chromium.chrome.test.util.BookmarkTestUtil.waitForBookmarkModelLoaded(BookmarkTestUtil.java:50)
	at org.chromium.chrome.browser.bookmarks.BookmarkBridgeTest.setUp(BookmarkBridgeTest.java:57)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
	at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37)
	at android.support.test.internal.statement.UiThreadStatement$1.run(UiThreadStatement.java:44)
	at android.app.Instrumentation$SyncRunnable.run(Instrumentation.java:1719)
	at android.os.Handler.handleCallback(Handler.java:733)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:136)
	at android.app.ActivityThread.main(ActivityThread.java:5001)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
	at dalvik.system.NativeStart.main(Native Method)

Comment 6 by mark@chromium.org, Jul 11 2017

Labels: -Sheriff-Chromium
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/43896 looks like the first build with this failure.
Thanks for looking that up.

The first time out reported in 739581 was over a week ago, so the Android dbg first failure is likely a red herring.
CL to annotate tests with @RetryOnFailure in the CQ: https://chromium-review.googlesource.com/566890
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/578c6b343fed9b641fe66284eafe33e6dd893c07

commit 578c6b343fed9b641fe66284eafe33e6dd893c07
Author: Theresa Wellington <twellington@google.com>
Date: Tue Jul 11 16:14:18 2017

Mark Android bookmark tests @RetryOnFailure

This reverts commit 5b5eabade0bbcd861198599ff65c33a9b8843b2f
and adds @RetryOnFailure to the bookmarks tests. These tests are
timing out on loading the bookmark model. No culprit has been
identified.

TBR=twellington@chromium.org
BUG= 740786 ,739581

Change-Id: If677168ca35b955a2a23ee5e81d1f8cc8338033a
Reviewed-on: https://chromium-review.googlesource.com/566890
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485645}
[modify] https://crrev.com/578c6b343fed9b641fe66284eafe33e6dd893c07/chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkBridgeTest.java
[modify] https://crrev.com/578c6b343fed9b641fe66284eafe33e6dd893c07/chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkModelTest.java

Mergedinto: 739581
Status: Duplicate (was: Available)

Sign in to add a comment