Tracks the initial implementation of linking to Desktop PWAs and future polish iterations.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d commit aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Thu Aug 03 04:26:40 2017 desktop-pwas: Open Bookmark app when link is within scope The DesktopPWAWindowing feature must be on in order for this to work. Makes it so that, once a user has installed a Bookmark App for a website, all navigations to that website will open the installed Bookmark App. This includes typing the address in the omnibox, clicking any links to an in-scope url, and opening any links to an in-scope url from the context menu. Future patches will change some of these so that the result is more intuitive. For example, if the user has installed https://www.foo.com through "Add to shelf" and the site's manifest defines scope as "/scope" and then the user visits https://www.foo.com/scope/test.html, a new app window to https://www.foo.com/scope/test.html will open. If the user navigated to https://www.foo.com/index.html, we would not open a new app window since the address is not in-scope as defined by the site's manifest. Three changes: 1. Use 'scope' in the site's manifest to create a url handler for the bookmark app. 2. Allow Hosted Apps that are Bookmark apps to use url handlers. This means that any non-bookmark hosted app that has url handlers will fail to load. 3. When handling a url that a Bookmark app could handle open the the bookmark app with the specified url. Bug: 740783 Change-Id: Iac69b13dc33be9ecd7336f24ae9021d5dd0161d0 Reviewed-on: https://chromium-review.googlesource.com/566199 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Matt Giuca <mgiuca@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#491644} [modify] https://crrev.com/aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d/chrome/browser/apps/app_url_redirector.cc [modify] https://crrev.com/aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d/chrome/browser/extensions/bookmark_app_helper.cc [modify] https://crrev.com/aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d/chrome/browser/extensions/bookmark_app_helper_unittest.cc [add] https://crrev.com/aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d/chrome/browser/extensions/bookmark_app_url_redirector_browsertest.cc [modify] https://crrev.com/aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d/chrome/browser/extensions/convert_web_app.cc [modify] https://crrev.com/aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d/chrome/browser/extensions/convert_web_app.h [modify] https://crrev.com/aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d/chrome/browser/extensions/convert_web_app_unittest.cc [modify] https://crrev.com/aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d/chrome/browser/extensions/crx_installer_browsertest.cc [modify] https://crrev.com/aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d/chrome/browser/extensions/extension_sync_data.cc [modify] https://crrev.com/aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d/chrome/browser/extensions/extension_sync_data.h [modify] https://crrev.com/aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d/chrome/browser/extensions/extension_sync_service.cc [modify] https://crrev.com/aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d/chrome/browser/sync/test/integration/two_client_apps_sync_test.cc [modify] https://crrev.com/aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d/chrome/browser/ui/extensions/application_launch.cc [modify] https://crrev.com/aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d/chrome/common/extensions/api/_manifest_features.json [modify] https://crrev.com/aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d/chrome/common/extensions/api/url_handlers/url_handlers_parser.cc [modify] https://crrev.com/aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d/chrome/common/web_application_info.h [modify] https://crrev.com/aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d/chrome/test/BUILD.gn [modify] https://crrev.com/aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d/components/sync/protocol/app_specifics.proto [modify] https://crrev.com/aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d/components/sync/protocol/proto_visitors.h [modify] https://crrev.com/aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d/extensions/common/manifest_constants.cc [modify] https://crrev.com/aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d/extensions/common/manifest_constants.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60 commit 4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60 Author: Tsuyoshi Horo <horo@chromium.org> Date: Thu Aug 03 06:28:06 2017 Revert "desktop-pwas: Open Bookmark app when link is within scope" This reverts commit aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d. Reason for revert: BookmarkAppUrlRedirectorBrowserTest.InAppNavigation fails BUG:751958 Original change's description: > desktop-pwas: Open Bookmark app when link is within scope > > The DesktopPWAWindowing feature must be on in order for this to work. > > Makes it so that, once a user has installed a Bookmark App for a website, all > navigations to that website will open the installed Bookmark App. This includes > typing the address in the omnibox, clicking any links to an in-scope url, and > opening any links to an in-scope url from the context menu. Future patches > will change some of these so that the result is more intuitive. > > For example, if the user has installed https://www.foo.com through > "Add to shelf" and the site's manifest defines scope as "/scope" and then the > user visits https://www.foo.com/scope/test.html, a new app window to > https://www.foo.com/scope/test.html will open. If the user > navigated to https://www.foo.com/index.html, we would not open a new app > window since the address is not in-scope as defined by the site's manifest. > > Three changes: > > 1. Use 'scope' in the site's manifest to create a url handler for > the bookmark app. > 2. Allow Hosted Apps that are Bookmark apps to use url handlers. > This means that any non-bookmark hosted app that has url handlers > will fail to load. > 3. When handling a url that a Bookmark app could handle open the > the bookmark app with the specified url. > > Bug: 740783 > Change-Id: Iac69b13dc33be9ecd7336f24ae9021d5dd0161d0 > Reviewed-on: https://chromium-review.googlesource.com/566199 > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Ben Wells <benwells@chromium.org> > Reviewed-by: Sky Malice <skym@chromium.org> > Reviewed-by: Matt Giuca <mgiuca@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491644} TBR=benwells@chromium.org,calamity@chromium.org,mgiuca@chromium.org,ortuno@chromium.org,skym@chromium.org,jochen@chromium.org Change-Id: I5e4bf4899d56fd2ffc1755b6cd5db0aa9c0c02d6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 740783 Reviewed-on: https://chromium-review.googlesource.com/599090 Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#491662} [modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/browser/apps/app_url_redirector.cc [modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/browser/extensions/bookmark_app_helper.cc [modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/browser/extensions/bookmark_app_helper_unittest.cc [delete] https://crrev.com/5d9135eee8b0e178efcd8b80e717f424fa8da677/chrome/browser/extensions/bookmark_app_url_redirector_browsertest.cc [modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/browser/extensions/convert_web_app.cc [modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/browser/extensions/convert_web_app.h [modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/browser/extensions/convert_web_app_unittest.cc [modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/browser/extensions/crx_installer_browsertest.cc [modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/browser/extensions/extension_sync_data.cc [modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/browser/extensions/extension_sync_data.h [modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/browser/extensions/extension_sync_service.cc [modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/browser/sync/test/integration/two_client_apps_sync_test.cc [modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/browser/ui/extensions/application_launch.cc [modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/common/extensions/api/_manifest_features.json [modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/common/extensions/api/url_handlers/url_handlers_parser.cc [modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/common/web_application_info.h [modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/test/BUILD.gn [modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/components/sync/protocol/app_specifics.proto [modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/components/sync/protocol/proto_visitors.h [modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/extensions/common/manifest_constants.cc [modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/extensions/common/manifest_constants.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7e79d45f171142ff9c5f04be34a97ac750fe2af commit e7e79d45f171142ff9c5f04be34a97ac750fe2af Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Thu Aug 03 10:16:15 2017 Reland "desktop-pwas: Open Bookmark app when link is within scope" This is a reland of aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d Added test files for the bookmark appp. Without these tests fail in release builds. Original change's description: > desktop-pwas: Open Bookmark app when link is within scope > > The DesktopPWAWindowing feature must be on in order for this to work. > > Makes it so that, once a user has installed a Bookmark App for a website, all > navigations to that website will open the installed Bookmark App. This includes > typing the address in the omnibox, clicking any links to an in-scope url, and > opening any links to an in-scope url from the context menu. Future patches > will change some of these so that the result is more intuitive. > > For example, if the user has installed https://www.foo.com through > "Add to shelf" and the site's manifest defines scope as "/scope" and then the > user visits https://www.foo.com/scope/test.html, a new app window to > https://www.foo.com/scope/test.html will open. If the user > navigated to https://www.foo.com/index.html, we would not open a new app > window since the address is not in-scope as defined by the site's manifest. > > Three changes: > > 1. Use 'scope' in the site's manifest to create a url handler for > the bookmark app. > 2. Allow Hosted Apps that are Bookmark apps to use url handlers. > This means that any non-bookmark hosted app that has url handlers > will fail to load. > 3. When handling a url that a Bookmark app could handle open the > the bookmark app with the specified url. > > Bug: 740783 > Change-Id: Iac69b13dc33be9ecd7336f24ae9021d5dd0161d0 > Reviewed-on: https://chromium-review.googlesource.com/566199 > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Ben Wells <benwells@chromium.org> > Reviewed-by: Sky Malice <skym@chromium.org> > Reviewed-by: Matt Giuca <mgiuca@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491644} TBR=benwells@chromium.org,mgiuca@chromium.org,skym@chromium.org,jochen@chromium.org Bug: 740783 Change-Id: I6fe97df85507d1e5fbb209ea0877c4345a8e03ab Reviewed-on: https://chromium-review.googlesource.com/599647 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#491692} [modify] https://crrev.com/e7e79d45f171142ff9c5f04be34a97ac750fe2af/chrome/browser/apps/app_url_redirector.cc [modify] https://crrev.com/e7e79d45f171142ff9c5f04be34a97ac750fe2af/chrome/browser/extensions/bookmark_app_helper.cc [modify] https://crrev.com/e7e79d45f171142ff9c5f04be34a97ac750fe2af/chrome/browser/extensions/bookmark_app_helper_unittest.cc [add] https://crrev.com/e7e79d45f171142ff9c5f04be34a97ac750fe2af/chrome/browser/extensions/bookmark_app_url_redirector_browsertest.cc [modify] https://crrev.com/e7e79d45f171142ff9c5f04be34a97ac750fe2af/chrome/browser/extensions/convert_web_app.cc [modify] https://crrev.com/e7e79d45f171142ff9c5f04be34a97ac750fe2af/chrome/browser/extensions/convert_web_app.h [modify] https://crrev.com/e7e79d45f171142ff9c5f04be34a97ac750fe2af/chrome/browser/extensions/convert_web_app_unittest.cc [modify] https://crrev.com/e7e79d45f171142ff9c5f04be34a97ac750fe2af/chrome/browser/extensions/crx_installer_browsertest.cc [modify] https://crrev.com/e7e79d45f171142ff9c5f04be34a97ac750fe2af/chrome/browser/extensions/extension_sync_data.cc [modify] https://crrev.com/e7e79d45f171142ff9c5f04be34a97ac750fe2af/chrome/browser/extensions/extension_sync_data.h [modify] https://crrev.com/e7e79d45f171142ff9c5f04be34a97ac750fe2af/chrome/browser/extensions/extension_sync_service.cc [modify] https://crrev.com/e7e79d45f171142ff9c5f04be34a97ac750fe2af/chrome/browser/sync/test/integration/two_client_apps_sync_test.cc [modify] https://crrev.com/e7e79d45f171142ff9c5f04be34a97ac750fe2af/chrome/browser/ui/extensions/application_launch.cc [modify] https://crrev.com/e7e79d45f171142ff9c5f04be34a97ac750fe2af/chrome/common/extensions/api/_manifest_features.json [modify] https://crrev.com/e7e79d45f171142ff9c5f04be34a97ac750fe2af/chrome/common/extensions/api/url_handlers/url_handlers_parser.cc [modify] https://crrev.com/e7e79d45f171142ff9c5f04be34a97ac750fe2af/chrome/common/web_application_info.h [modify] https://crrev.com/e7e79d45f171142ff9c5f04be34a97ac750fe2af/chrome/test/BUILD.gn [add] https://crrev.com/e7e79d45f171142ff9c5f04be34a97ac750fe2af/chrome/test/data/extensions/bookmark_apps/url_handlers/in_scope/index.html [add] https://crrev.com/e7e79d45f171142ff9c5f04be34a97ac750fe2af/chrome/test/data/extensions/bookmark_apps/url_handlers/in_scope/other.html [add] https://crrev.com/e7e79d45f171142ff9c5f04be34a97ac750fe2af/chrome/test/data/extensions/bookmark_apps/url_handlers/out_of_scope/other.html [modify] https://crrev.com/e7e79d45f171142ff9c5f04be34a97ac750fe2af/components/sync/protocol/app_specifics.proto [modify] https://crrev.com/e7e79d45f171142ff9c5f04be34a97ac750fe2af/components/sync/protocol/proto_visitors.h [modify] https://crrev.com/e7e79d45f171142ff9c5f04be34a97ac750fe2af/extensions/common/manifest_constants.cc [modify] https://crrev.com/e7e79d45f171142ff9c5f04be34a97ac750fe2af/extensions/common/manifest_constants.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72165fb7b2d4170598596d35d21f51f58c99b126 commit 72165fb7b2d4170598596d35d21f51f58c99b126 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Mon Aug 07 06:25:53 2017 desktop-pwas: Use "start_url" for the scope if "scope" is not present. According to the Web Manifest "within scope" algorithm[1], if "scope" is not present then *any* target URL is within scope. This is too broad so Android uses the path of "start_url" to generate an acceptable scope. This patch matches Android and uses "start_url" to generate a scope. [1] https://w3c.github.io/manifest/#dfn-within-scope Bug: 740783 Change-Id: I3c0ac943981dc10863d92a23742a0566e907c6f4 Reviewed-on: https://chromium-review.googlesource.com/583974 Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Matt Giuca <mgiuca@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#492272} [modify] https://crrev.com/72165fb7b2d4170598596d35d21f51f58c99b126/chrome/browser/extensions/bookmark_app_helper.cc [modify] https://crrev.com/72165fb7b2d4170598596d35d21f51f58c99b126/chrome/browser/extensions/bookmark_app_helper_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44967f354db003d472904e84f58d91a16959a004 commit 44967f354db003d472904e84f58d91a16959a004 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Tue Aug 08 02:18:00 2017 desktop-pwas: Refactor tests to more closely match real actions Before, we were using test-specific methods to navigate tabs to URLs. Now, we more closely match the real test cases, by creating websites with links and clicking on them. Bug: 740783 Change-Id: Idd460590da3ed4095d7d70fa1353da59fd8edb97 Reviewed-on: https://chromium-review.googlesource.com/593006 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Matt Giuca <mgiuca@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#492505} [modify] https://crrev.com/44967f354db003d472904e84f58d91a16959a004/chrome/browser/apps/app_url_redirector.cc [modify] https://crrev.com/44967f354db003d472904e84f58d91a16959a004/chrome/browser/extensions/bookmark_app_url_redirector_browsertest.cc [delete] https://crrev.com/ef7f14b6ae025efb48b1d8e244ced534910f4b30/chrome/test/data/extensions/bookmark_apps/url_handlers/in_scope/index.html [delete] https://crrev.com/ef7f14b6ae025efb48b1d8e244ced534910f4b30/chrome/test/data/extensions/bookmark_apps/url_handlers/in_scope/other.html [delete] https://crrev.com/ef7f14b6ae025efb48b1d8e244ced534910f4b30/chrome/test/data/extensions/bookmark_apps/url_handlers/out_of_scope/other.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa8f9f6c31328ec15f0a34cff57e3dbbfc7f2394 commit fa8f9f6c31328ec15f0a34cff57e3dbbfc7f2394 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Wed Aug 09 04:08:05 2017 desktop-pwas: Only open app for link navigations. Only PAGE_TRANSITION_LINK will open a new App window. The remaining types of PageTransitions[1] won't. [1] https://cs.chromium.org/chromium/src/ui/base/page_transition_types.h Bug: 740783, 753240 , 753239 Change-Id: I4230137cdbaf9b0f8b909c5d8cf8457e03884b07 Reviewed-on: https://chromium-review.googlesource.com/593447 Reviewed-by: Matt Giuca <mgiuca@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#492819} [modify] https://crrev.com/fa8f9f6c31328ec15f0a34cff57e3dbbfc7f2394/chrome/browser/apps/app_url_redirector.cc [modify] https://crrev.com/fa8f9f6c31328ec15f0a34cff57e3dbbfc7f2394/chrome/browser/extensions/bookmark_app_url_redirector_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c04e98665131dd265a5849de53cee54355397627 commit c04e98665131dd265a5849de53cee54355397627 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Thu Aug 10 06:06:39 2017 desktop-pwas: Refactor tests so that they share more code. Abstracts common code from tests to avoid repetition. Bug: 740783 Change-Id: I5cffa4651b9a8178ac21f0cf33d85d10bbf3ddc4 Reviewed-on: https://chromium-review.googlesource.com/609053 Reviewed-by: Matt Giuca <mgiuca@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#493304} [modify] https://crrev.com/c04e98665131dd265a5849de53cee54355397627/chrome/browser/extensions/bookmark_app_url_redirector_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/460cc3e4fded826996636cbeb0769dd4c1060d16 commit 460cc3e4fded826996636cbeb0769dd4c1060d16 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Tue Aug 29 07:59:22 2017 desktop-pwas: Add tests for all transition types Adds tests to make sure all transition types result in the correct outcome. Bug: 740783, 753239 Change-Id: I1000dcb08ace494e6fa4d962b934cb7b07f0f507 Reviewed-on: https://chromium-review.googlesource.com/618202 Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Matt Giuca <mgiuca@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#498044} [modify] https://crrev.com/460cc3e4fded826996636cbeb0769dd4c1060d16/chrome/browser/extensions/bookmark_app_url_redirector_browsertest.cc [modify] https://crrev.com/460cc3e4fded826996636cbeb0769dd4c1060d16/content/public/test/test_frame_navigation_observer.cc [modify] https://crrev.com/460cc3e4fded826996636cbeb0769dd4c1060d16/content/public/test/test_frame_navigation_observer.h [modify] https://crrev.com/460cc3e4fded826996636cbeb0769dd4c1060d16/ui/base/page_transition_types.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbf2395c6157cba65998f00abf67f772ac22c733 commit cbf2395c6157cba65998f00abf67f772ac22c733 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Tue Nov 28 08:37:26 2017 desktop-pwas: Add histogram for launching source for Bookmark Apps Record the source for the launch of Bookmark Apps e.g. url handler, shelf, etc. Bug: 740783, 785661 Change-Id: Iede87c91d024bbcb9d797be522fbd2e45723d415 Reviewed-on: https://chromium-review.googlesource.com/595368 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#519612} [modify] https://crrev.com/cbf2395c6157cba65998f00abf67f772ac22c733/chrome/browser/ui/extensions/application_launch.cc [modify] https://crrev.com/cbf2395c6157cba65998f00abf67f772ac22c733/tools/metrics/histograms/histograms.xml
Support
Issue 857255 has been merged into this issue.
Comment 1 by ortuno@chromium.org
, Jul 11 2017