[MD settings] update startup pages when NTP extension is enabled/disabled |
|||
Issue descriptionin Chrome://settings on the OnStartup Pages subpage, if the ntp extension is enabled/disabled, the settings UI does not update. I noticed this while looking at Issue 740434 , so that may help with context. Here's some repro notes from that bug: URL: https://chrome.google.com/webstore/detail/momentum/laookkfknpbbblfpciffpaejjkokdgca?hl=en Steps: 1. Launch Chrome and add above extension (url given) 2. Navigate to chrome://settings/startupUrls, click on 'Disable' button of added extension and observe then: 3. In a *new or different tab* go to chrome://extensions and enable the extension. 4. Look back at the startup pages subpage. Problem: it doesn't reappear in the settings page.
,
Jul 11 2017
@dschuyler: Can you check if this is a duplicate of issue 704464?
,
Jul 11 2017
@#2, that issue talks about a few different (though similar to a user point of view) issues. This issue is specifically for issue 704464, comment #1 on the second screen shot: on-startup2.png. I'll mark this issue as blocking that issue since this is a piece of it, but doesn't cover all the issues mentioned in issue 704464.
,
Jul 12 2017
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c50f7be2ac7cfc309d33d0d600735712894fbd6 commit 7c50f7be2ac7cfc309d33d0d600735712894fbd6 Author: Dave Schuyler <dschuyler@chromium.org> Date: Fri Jul 14 02:45:44 2017 [MD settings] listen for ntp extension changes This CL observes changes to extensions that may control the NTP and sends that information to the OnStartup settings page. Bug: 740779 Change-Id: Icdc539f0fcb64eeb6f0dc6f8eb9ade061d4e870e Reviewed-on: https://chromium-review.googlesource.com/567419 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#486645} [modify] https://crrev.com/7c50f7be2ac7cfc309d33d0d600735712894fbd6/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js [modify] https://crrev.com/7c50f7be2ac7cfc309d33d0d600735712894fbd6/chrome/browser/ui/webui/settings/md_settings_ui.cc [modify] https://crrev.com/7c50f7be2ac7cfc309d33d0d600735712894fbd6/chrome/browser/ui/webui/settings/on_startup_handler.cc [modify] https://crrev.com/7c50f7be2ac7cfc309d33d0d600735712894fbd6/chrome/browser/ui/webui/settings/on_startup_handler.h [add] https://crrev.com/7c50f7be2ac7cfc309d33d0d600735712894fbd6/chrome/browser/ui/webui/settings/on_startup_handler_unittest.cc [modify] https://crrev.com/7c50f7be2ac7cfc309d33d0d600735712894fbd6/chrome/test/BUILD.gn
,
Jul 14 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dpa...@chromium.org
, Jul 11 2017