Polymer WebUI: Pulsate modal dialog when clicking outside. |
||||
Issue descriptionThe old Options UI had a nice "pulse" effect when the user clicked outside of a modal dialog, see old_pulse_dialog.mp4. This was dropped from new Settings. Re-instating is fairly easy, and since we share cr-dialog across all of Polymer WebUI pages, it would take effect on all of them, not just Settings. See how it would look at pulse_dialog.mp4 screencast.
,
Jul 11 2017
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1da9af16908d1288e8c9d08b6bd27e964b4ae15c commit 1da9af16908d1288e8c9d08b6bd27e964b4ae15c Author: dpapad <dpapad@chromium.org> Date: Wed Jul 12 22:20:59 2017 Polymer WebUI: Add "pulse" effect when clicking outside cr-dialog. This matches the behavior of old Options, but it will also show up an all Polymer WebUI pages using cr-dialog. Bug: 740771 Change-Id: Ieb5db50b4796264a87be38e01ebfd1f362ff9d39 Reviewed-on: https://chromium-review.googlesource.com/566093 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#486135} [modify] https://crrev.com/1da9af16908d1288e8c9d08b6bd27e964b4ae15c/ui/webui/resources/cr_elements/cr_dialog/compiled_resources2.gyp [modify] https://crrev.com/1da9af16908d1288e8c9d08b6bd27e964b4ae15c/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js
,
Jul 12 2017
,
Jul 18 2017
Tested this issue on Windows 7, Mac 10.12.5 & Ubuntu 14.04 using chrome #61.0.3159.5 as per the screen casts provided in comment#0. Observed 'pulse' effect on chrome://settings page & chrome://bookmark pages. dpapad@, Please let us know any other webpages to be tested further? Please find the attached screencast for reference. Thanks..!! |
||||
►
Sign in to add a comment |
||||
Comment 1 by dpa...@chromium.org
, Jul 11 2017