Run unittests on fuchsia with DCHECK's enabled |
|||||
Issue descriptionCurrently Fuchsia bot runs tests only in release mode without DCHECKs. Many tests that succeed on the but fail when compiled with DCHECK. Ideally the bot should compile tests in Debug mode. If that's not feasible then at least we we need dcheck_always_on=true.
,
Jul 11 2017
Triaging to Client component, jbudorick@ ,if there is a more specific place, please move.
,
Jul 15 2017
I'm assuming you're talking about chromium.fyi:Fuchsia, chromium.fyi:Fuchsia (dbg), and tryserver.chromium.linux:fuchsia. If that's wrong, please let me know (and point me in the direction of the bot, because I see no other fuchsia bots listed in any of our master configurations). typical configuration is: - trybot (release+DCHECKs) - waterfall release bot (release w/o DCHECKs) - waterfall debug bot Fuchsia's bots' current configuration has the trybot running w/o dchecks. I'll send out a CL shortly that changes that to match the norm.
,
Jul 15 2017
er, sorry, misread mb_config. fuchsia already matches the typical case. This would deviate. Given that Fuchsia (dbg) exists, I think the only option here is switching the waterfall Fuchsia bot to have DCHECKs enabled, which is a deviation from how we typically configure waterfall bots. If that's what y'all want, though, that's fine with me.
,
Jul 15 2017
Re #4: Is it only try-bots which have dcheck_always_on, then, and waterfall/Release bots don't? I'm happy with this being covered by the Debug bot, in which case we should try to expedite getting that green (see issue 743296 ).
,
Jul 15 2017
#5: sgtm |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by w...@chromium.org
, Jul 11 2017