New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 740768 link

Starred by 2 users
Status: Fixed
Owner:
█ ayanaadylova@google.com
Email to this user bounced
Closed: Jul 2017
Cc:
█ ayanaadylova@google.com
█ cwpayton@google.com
hinoka@chromium.org
sergeybe...@chromium.org
no...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Participants' hotlists:
luci-config-ui


Sign in to add a comment

config_service: Make the iron-ajax call on-response handler automatically in tests

Project Member Reported by ayanaadylova@google.com, Jul 11 2017 
Chrome Version: 59.0.3071.115

What is the expected result?
Iron-ajax request in tests should automatically call on-response handler.

What happens instead?
Iron-ajax request in tests does not automatically call on-response handler so I have to call it manually.

Comment 1 by sergeybe...@chromium.org, Jul 11 2017

Cc: ayanaadylova@google.com cwpayton@google.com
Owner: ----
Context: https://crrev.com/2959833002

This might give us a clue on how to write such a test: https://github.com/PolymerElements/iron-ajax/blob/master/test/iron-ajax.html#L649
In particular, the test should somehow wait for the request to complete. Then _onGotConfigFiles() will be called by the element, and we can test its side-effects.
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 11 2017

Labels: Hotlist-Google

Comment 3 by sergeybe...@chromium.org, Jul 13 2017

Summary: config_service: Make the iron-ajax call on-response handler automatically in tests (was: Make the iron-ajax call on-response handler automatically.)

Comment 4 by tandrii@chromium.org, Jul 18 2017

Status: Available (was: Untriaged)

Comment 5 by ayanaadylova@google.com, Jul 18 2017

Owner: ayanaadylova@google.com
Status: Started (was: Available)

Comment 7 by ayanaadylova@google.com, Jul 24 2017

Status: Fixed (was: Started)
►

Sign in to add a comment