New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740758 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 726546



Sign in to add a comment

MD Extensions: unify paper-button style with MD Settings

Project Member Reported by scottchen@chromium.org, Jul 10 2017

Issue description

Currently the paper-button styles in MD Extensions looks drastically different from MD Settings, and is individually styled on a per-use basis. 

We should figure out how to reuse MD Setting's paper-button/ripple styles (maybe moved to a new cr_elements/button_style_css.html?)
 
Blocking: 726546
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f82c88750d41d0f34d9c3aba823af1008b78f1d

commit 7f82c88750d41d0f34d9c3aba823af1008b78f1d
Author: Scott Chen <scottchen@chromium.org>
Date: Mon Jul 17 23:52:59 2017

WebUI: move paper-button styling to shared location.

This allows WebUI sections outside of settings/ to reuse the same styles.

Bug:  740758 
Change-Id: Iefbdff0b219a3ced28b02098a0f05bbe25f83357
Reviewed-on: https://chromium-review.googlesource.com/571189
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487289}
[modify] https://crrev.com/7f82c88750d41d0f34d9c3aba823af1008b78f1d/chrome/browser/resources/md_extensions/pack_dialog.html
[modify] https://crrev.com/7f82c88750d41d0f34d9c3aba823af1008b78f1d/chrome/browser/resources/md_extensions/shortcut_input.html
[modify] https://crrev.com/7f82c88750d41d0f34d9c3aba823af1008b78f1d/chrome/browser/resources/md_extensions/toolbar.html
[modify] https://crrev.com/7f82c88750d41d0f34d9c3aba823af1008b78f1d/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html
[modify] https://crrev.com/7f82c88750d41d0f34d9c3aba823af1008b78f1d/chrome/browser/resources/settings/controls/controlled_button.html
[modify] https://crrev.com/7f82c88750d41d0f34d9c3aba823af1008b78f1d/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/7f82c88750d41d0f34d9c3aba823af1008b78f1d/chrome/browser/resources/settings/settings_vars_css.html
[add] https://crrev.com/7f82c88750d41d0f34d9c3aba823af1008b78f1d/ui/webui/resources/cr_elements/paper_button_style_css.html
[modify] https://crrev.com/7f82c88750d41d0f34d9c3aba823af1008b78f1d/ui/webui/resources/cr_elements/shared_vars_css.html
[modify] https://crrev.com/7f82c88750d41d0f34d9c3aba823af1008b78f1d/ui/webui/resources/cr_elements_resources.grdp

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bf6753c39cca68127922a079c11e07097202205

commit 9bf6753c39cca68127922a079c11e07097202205
Author: Scott Chen <scottchen@chromium.org>
Date: Thu Jul 20 21:56:32 2017

MD Extensions: reuse the shared paper-button styling.

This CL eliminates the redundant css rules for paper-button in favor of reusing the styling in the shared cr_elements location.

Bug:  740758 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ieba6ab6bf03e2c063a52323ecacaafc5919e4dfa
Reviewed-on: https://chromium-review.googlesource.com/577027
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488425}
[modify] https://crrev.com/9bf6753c39cca68127922a079c11e07097202205/chrome/browser/resources/md_extensions/item.html
[modify] https://crrev.com/9bf6753c39cca68127922a079c11e07097202205/chrome/browser/resources/md_extensions/load_error.html
[modify] https://crrev.com/9bf6753c39cca68127922a079c11e07097202205/chrome/browser/resources/md_extensions/pack_dialog.html
[modify] https://crrev.com/9bf6753c39cca68127922a079c11e07097202205/chrome/browser/resources/md_extensions/toolbar.html

Status: Fixed (was: Started)

Comment 6 by dpa...@chromium.org, Mar 12 2018

Components: UI>Browser>ExtensionsManagement

Sign in to add a comment