New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740750 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 724708



Sign in to add a comment

EasyUnlock v2: Clean up enable proximity detection code

Project Member Reported by tengs@chromium.org, Jul 10 2017

Issue description

In EasyUnlock v2, we enable proximity detection by default, so there is no need for this setting anymore.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/260a30f320ba85e6ac5b6f3bb9517a4e37e3cc09

commit 260a30f320ba85e6ac5b6f3bb9517a4e37e3cc09
Author: Tim Song <tengs@chromium.org>
Date: Thu Jul 13 00:42:08 2017

[EasyUnlock] Clean up enable proximity detection setting.

BUG= 740750 

Change-Id: I7bdc4934dd8ace5c4ce317b6f7f48fe8c73ec5dc
Reviewed-on: https://chromium-review.googlesource.com/565964
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486188}
[modify] https://crrev.com/260a30f320ba85e6ac5b6f3bb9517a4e37e3cc09/chrome/app/settings_strings.grdp
[modify] https://crrev.com/260a30f320ba85e6ac5b6f3bb9517a4e37e3cc09/chrome/browser/about_flags.cc
[modify] https://crrev.com/260a30f320ba85e6ac5b6f3bb9517a4e37e3cc09/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
[modify] https://crrev.com/260a30f320ba85e6ac5b6f3bb9517a4e37e3cc09/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/260a30f320ba85e6ac5b6f3bb9517a4e37e3cc09/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/260a30f320ba85e6ac5b6f3bb9517a4e37e3cc09/chrome/browser/resources/options/browser_options.html
[modify] https://crrev.com/260a30f320ba85e6ac5b6f3bb9517a4e37e3cc09/chrome/browser/resources/options/browser_options.js
[modify] https://crrev.com/260a30f320ba85e6ac5b6f3bb9517a4e37e3cc09/chrome/browser/resources/settings/people_page/lock_screen.html
[modify] https://crrev.com/260a30f320ba85e6ac5b6f3bb9517a4e37e3cc09/chrome/browser/resources/settings/people_page/lock_screen.js
[modify] https://crrev.com/260a30f320ba85e6ac5b6f3bb9517a4e37e3cc09/chrome/browser/signin/easy_unlock_service.cc
[modify] https://crrev.com/260a30f320ba85e6ac5b6f3bb9517a4e37e3cc09/chrome/browser/signin/easy_unlock_service.h
[modify] https://crrev.com/260a30f320ba85e6ac5b6f3bb9517a4e37e3cc09/chrome/browser/signin/easy_unlock_service_regular.cc
[modify] https://crrev.com/260a30f320ba85e6ac5b6f3bb9517a4e37e3cc09/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/260a30f320ba85e6ac5b6f3bb9517a4e37e3cc09/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.cc
[modify] https://crrev.com/260a30f320ba85e6ac5b6f3bb9517a4e37e3cc09/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/260a30f320ba85e6ac5b6f3bb9517a4e37e3cc09/chrome/common/pref_names.cc
[modify] https://crrev.com/260a30f320ba85e6ac5b6f3bb9517a4e37e3cc09/chrome/common/pref_names.h
[modify] https://crrev.com/260a30f320ba85e6ac5b6f3bb9517a4e37e3cc09/chrome/test/data/webui/settings/easy_unlock_browsertest_chromeos.js
[modify] https://crrev.com/260a30f320ba85e6ac5b6f3bb9517a4e37e3cc09/components/proximity_auth/switches.cc
[modify] https://crrev.com/260a30f320ba85e6ac5b6f3bb9517a4e37e3cc09/components/proximity_auth/switches.h

Comment 2 by tengs@chromium.org, Jul 13 2017

Status: Fixed (was: Assigned)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment