New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 740742 link

Starred by 1 user
Status: Verified
Owner:
█ bshe@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

App intent exits VR

Project Member Reported by ddorwin@chromium.org, Jul 10 2017 
Chrome Version: 61.0.3153.0
OS: Android

What steps will reproduce the problem?
(0) Make sure the Vimeo native app is not installed.
(1) Navigate to vimeo.com.
(2) Put the phone in the headset.
(3) Click the "OPEN IN APP" button at the bottom of the page.

What is the expected result?
The user should remain in VR. Ideally, we might display an error message that this action cannot be completed in VR.

What happens instead?
The 2D Google Play app is displayed (across the entire screen). Interestingly, it appears to be on a generic page and not one specific to Vimeo.

Comment 1 by ddorwin@chromium.org, Jul 10 2017

Labels: -Restrict-View-Google
Here is the link source:
<a data-action="app_banner.openapp" class="app_banner_button btn btn_white js-app_banner_open_app" data-deep-link="explore" data-source-context="loggedout" href="http://bnc.lt/a/key_live_...?%24deeplink_path=app.vimeo.com%2Fexplore&amp;%24always_deeplink=true&amp;channel=vimeo&amp;ref=mobileweb&amp;context=mobileweb&amp;tags%5B%5D=banner&amp;tags%5B%5D=loggedout&amp;feature=dashboard">
 <span class="btn_text btn_text-open">Open in app</span>
 <!--Remove after AB test-->
 <span class="btn_text btn_text-get">Get the Vimeo App</span>
 </a>

Comment 2 by bshe@chromium.org, Jul 11 2017

Owner: bshe@chromium.org
Status: Started (was: Available)
should be fixed by https://chromium-review.googlesource.com/c/563883/
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80510be87e60be914b4828e2ba2f069239fceabc

commit 80510be87e60be914b4828e2ba2f069239fceabc
Author: bshe <bshe@chromium.org>
Date: Wed Jul 12 14:24:54 2017

Show DOFF instead of non VR content

non VR content includes:
1. 2D Dialog for external navigation request while in incognito mode
2. external 2D app


Bug: 739778,  740742 
Change-Id: Idd1de302a1412a1815b6d64fc7db5ac6b8a458ed
Reviewed-on: https://chromium-review.googlesource.com/563883
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485942}
[modify] https://crrev.com/80510be87e60be914b4828e2ba2f069239fceabc/chrome/android/java/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateImpl.java
[modify] https://crrev.com/80510be87e60be914b4828e2ba2f069239fceabc/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[add] https://crrev.com/80510be87e60be914b4828e2ba2f069239fceabc/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrExternalNavigationDelegate.java
[modify] https://crrev.com/80510be87e60be914b4828e2ba2f069239fceabc/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/80510be87e60be914b4828e2ba2f069239fceabc/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/80510be87e60be914b4828e2ba2f069239fceabc/chrome/android/java_sources.gni

Comment 4 by bshe@chromium.org, Jul 13 2017

Status: Fixed (was: Started)

Comment 5 by vsupruniuk@google.com, Aug 10 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment