New issue
Advanced search Search tips

Issue 740737 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Sep 4
Cc:
vmp...@chromium.org
ericrk@chromium.org
cblume@chromium.org
enne@chromium.org
khushals...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Investigate null images in GpuImageDecodeCache::UploadImageIfNecessary

Project Member Reported by ccameron@chromium.org, Jul 10 2017 
There have existed since the beginning of time several DCHECKs that uploaded_image in this function be non-null.

Image color correction acted on this assumption an dereferenced these images, resulting in tons of renderer crashes (see issue 738898).

Investigate why that assumption was invalid. This may be similar to the investigation done in issue 721744.

Comment 1 by enne@chromium.org, Sep 1 2017 

I ran into this issue locally.

At fc4a030ef79d7296978a33353dc123ac260a4ce1 (r498899) on tip of tree for Linux (at least), if you run with --enable-gpu-rasterization --enable-oop-rasterization and navigate to reddit.com, it causes a deserialization error due to https://chromium-review.googlesource.com/c/chromium/src/+/648213.  This can be replicated by just returning error::kInvalidArguments at the start of GLES2DecoderImpl::HandleRasterCHROMIUM and passing those above flags.

This error eventually causes one of the gpu mode images to fail to upload in the renderer.  ToT ignores this with a TODO, but ericrk's https://chromium-review.googlesource.com/c/chromium/src/+/544102 turns this back into a DCHECK.

This seems likely to be at least one reason why uploaded image can be null.

Comment 2 by enne@chromium.org, Sep 1 2017 

...where "this" is a gpu process crash or some unexpected command buffer error.
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 3

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by enne@chromium.org, Sep 4

Status: Fixed (was: Untriaged)
I think we handle this now and understand why.
►

Sign in to add a comment