New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740734 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

WebUSB API Crashed browser

Project Member Reported by mwills@google.com, Jul 10 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36

Steps to reproduce the problem:
Use go/web-flashstation

What is the expected behavior?
Browser does not crash

What went wrong?
Entire browser crashed

Crashed report ID: 24691ad308000000

How much crashed? Whole browser

Is it a problem with a plugin? No 

Did this work before? N/A 

Chrome version: 59.0.3071.115  Channel: stable
OS Version: 10.0.14393
Flash Version: 

original reporter edheyl@
not consistently reproducible
 
Labels: -Pri-2 M-61 Pri-1
Owner: reillyg@chromium.org
Status: Assigned (was: Unconfirmed)
0x00007ff981d0a18b	(chrome.dll -usb_device_handle_impl.cc:868 )	device::UsbDeviceHandleImpl::ClaimInterfaceComplete(scoped_refptr<device::UsbDeviceHandleImpl::InterfaceClaimer>,base::Callback<void ,1,1> const &)
0x00007ff981d0c7ba	(chrome.dll -bind_internal.h:339 )	base::internal::Invoker<base::internal::BindState<void ( device::UsbDeviceHandleImpl::*)(scoped_refptr<device::UsbDeviceHandleImpl::InterfaceClaimer>,base::Callback<void ,1,1> const &),scoped_refptr<device::UsbDeviceHandleImpl>,scoped_refptr<device::UsbDeviceHandleImpl::InterfaceClaimer>,base::Callback<void ,1,1> >,void >::Run(base::internal::BindStateBase *)
0x00007ff9813b2daf	(chrome.dll -task_annotator.cc:59 )	base::debug::TaskAnnotator::RunTask(char const *,base::PendingTask *)
0x00007ff981364b85	(chrome.dll -message_loop.cc:423 )	base::MessageLoop::RunTask(base::PendingTask *)
0x00007ff981365736	(chrome.dll -message_loop.cc:527 )	base::MessageLoop::DoWork()
0x00007ff9813b3350	(chrome.dll -message_pump_win.cc:173 )	base::MessagePumpForUI::DoRunLoop()
0x00007ff9813b2fa3	(chrome.dll -message_pump_win.cc:56 )	base::MessagePumpWin::Run(base::MessagePump::Delegate *)
0x00007ff98138cbbf	(chrome.dll -run_loop.cc:37 )	base::RunLoop::Run()
0x00007ff98128651f	(chrome.dll -chrome_browser_main.cc:1977 )	ChromeBrowserMainParts::MainMessageLoopRun(int *)
0x00007ff980d1380b	(chrome.dll -browser_main_runner.cc:140 )	content::BrowserMainRunnerImpl::Run()
0x00007ff980d0c148	(chrome.dll -browser_main.cc:46 )	content::BrowserMain(content::MainFunctionParams const &)
0x00007ff9812384f3	(chrome.dll -content_main_runner.cc:740 )	content::ContentMainRunnerImpl::Run()
0x00007ff981d383c7	(chrome.dll -main.cc:179 )	service_manager::Main(service_manager::MainParams const &)
0x00007ff9809ecf64	(chrome.dll -chrome_main.cc:123 )	ChromeMain
0x00007ff633447510	(chrome.exe -main_dll_loader_win.cc:202 )	MainDllLoader::Launch(HINSTANCE__ *,base::TimeTicks)
0x00007ff6334425da	(chrome.exe -chrome_exe_main_win.cc:271 )	wWinMain
0x00007ff6334dc7e2	(chrome.exe -exe_common.inl:253 )	__scrt_common_main_seh
0x00007ff9b2658363	(KERNEL32.DLL + 0x00008363 )	BaseThreadInitThunk
0x00007ff9b44b70d0	(ntdll.dll + 0x000670d0 )	RtlUserThreadStart
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 11 2017

Labels: Hotlist-Google
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab8294b78d50bfdfbed96aef8859a1d03cc4ec06

commit ab8294b78d50bfdfbed96aef8859a1d03cc4ec06
Author: Reilly Grant <reillyg@chromium.org>
Date: Tue Jul 11 17:33:05 2017

Check for nullptr in ClaimInterfaceComplete

If the device is disconnected and the interface claim failed at the same
time then |interface_claimer| will be null and there will be nothing to
release on the blocking thread.

Bug:  740734 
Change-Id: I25a51cd25e3d1af51007c6c617ffbf596d5fb89a
Reviewed-on: https://chromium-review.googlesource.com/565946
Reviewed-by: Jun Cai <juncai@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485668}
[modify] https://crrev.com/ab8294b78d50bfdfbed96aef8859a1d03cc4ec06/device/usb/usb_device_handle_impl.cc

Status: Fixed (was: Assigned)
Cc: krajshree@chromium.org
Labels: Needs-Feedback
Tried testing the issue on Win-10 by navigating to URL: go/web-flashstation provided in comment #0.
But it generated an "UberProxy" error.

reillyg@ - Could you please provide any other sample URL to verify the issue from TE-end.

Thanks...!!
mwills@, please check that this fix has resolved the reported issue as this is an internal URL and if so mark this issue as "Verified".

Comment 7 by mwills@google.com, Jul 18 2017

This wasn't something that we had a good repro case for, it just happened sometimes. (I also don't have access to mark the issue verified anyway)

Sign in to add a comment