Issue metadata
Sign in to add a comment
|
Don't use BlobStatus::ERR_FILE_WRITE_FAILED for two completely unrelated errors |
||||||||||||||||||||||||
Issue descriptionCurrently this same blob status is used for: 1) the renderer failed to write data to a file 2) the renderer tried creating a blob referencing a file the renderer doesn't have access to. Since those cases are really completely different, it probably makes more sense to not use the same error code for both.
,
Nov 7 2017
Apologies, applied the wrong component in bulk.
,
Nov 8 2017
Setting Internals>Services>Storage to all children of issue 611935
,
Jan 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f28782d5fe8e508e75f82e49c78b4fbc060c8de commit 4f28782d5fe8e508e75f82e49c78b4fbc060c8de Author: Marijn Kruisselbrink <mek@chromium.org> Date: Wed Jan 10 22:16:07 2018 Stop using BlobStatus::ERR_FILE_WRITE_FAILED for two unrelated reasons. Instead introduce ERR_REFERENCED_FILE_UNAVAILABLE for the case where a blob tries to reference a file it doesn't have access to. Bug: 740730 Change-Id: I66616c5fcfcbf788a53d1a22fb0b2af618edffb5 Reviewed-on: https://chromium-review.googlesource.com/860279 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#528443} [modify] https://crrev.com/4f28782d5fe8e508e75f82e49c78b4fbc060c8de/content/browser/blob_storage/blob_dispatcher_host.cc [modify] https://crrev.com/4f28782d5fe8e508e75f82e49c78b4fbc060c8de/storage/browser/blob/blob_reader.cc [modify] https://crrev.com/4f28782d5fe8e508e75f82e49c78b4fbc060c8de/storage/browser/blob/blob_registry_impl.cc [modify] https://crrev.com/4f28782d5fe8e508e75f82e49c78b4fbc060c8de/storage/browser/blob/blob_registry_impl_unittest.cc [modify] https://crrev.com/4f28782d5fe8e508e75f82e49c78b4fbc060c8de/storage/browser/blob/view_blob_internals_job.cc [modify] https://crrev.com/4f28782d5fe8e508e75f82e49c78b4fbc060c8de/storage/common/blob_storage/blob_storage_constants.h [modify] https://crrev.com/4f28782d5fe8e508e75f82e49c78b4fbc060c8de/tools/metrics/histograms/enums.xml
,
Jan 10 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by laforge@google.com
, Nov 7 2017