New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 740727 link

Starred by 2 users
Status: Archived
Owner:
skau@chromium.org
Closed: Aug 2017
Cc:
adlr@chromium.org
█ justincarlson@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

USB printer display names may need internationalization

Project Member Reported by justincarlson@chromium.org, Jul 10 2017 
Per comments on https://chromium-review.googlesource.com/c/563521/1/chrome/browser/chromeos/printing/usb_printer_util.cc#164, 

we are probably not doing the right thing w.r.t. generating internationalized display names for USB printers.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fb756e0abbc3114bf9d88fba73193da020f4efb

commit 3fb756e0abbc3114bf9d88fba73193da020f4efb
Author: Sean Kau <skau@chromium.org>
Date: Fri Jul 21 01:36:02 2017

Localize the generated USB Printer display name.

Bug:  740727 
Change-Id: I1f75fe169e0728c7e5e27a870c1c1cab8e047396
Reviewed-on: https://chromium-review.googlesource.com/580530
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488539}
[modify] https://crrev.com/3fb756e0abbc3114bf9d88fba73193da020f4efb/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/3fb756e0abbc3114bf9d88fba73193da020f4efb/chrome/browser/chromeos/printing/usb_printer_util.cc

Comment 2 by adlr@chromium.org, Jul 25 2017 

Should we keep doing work here?

Comment 3 by skau@chromium.org, Aug 11 2017

Cc: justincarlson@chromium.org adlr@chromium.org
Labels: OS-Chrome
Owner: skau@chromium.org
Status: Fixed (was: Untriaged)
This is fixed.  I forgot to close it since I never took ownership of it.

Comment 4 by skau@chromium.org, Aug 11 2017 

It would be nice to get this merged back to M61, but we missed the cutoff for strings.

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment