Verbose state for omnibox views should match icon color |
||||||||||
Issue descriptionChrome Version: 59 OS: Windows, Chrome OS What steps will reproduce the problem? (1) Visit http-login.badssl.com What is the expected result? The verbose text color matches the info icon What happens instead? The verbose text color is black Please use labels and text to provide additional information. spqchan@, could you triage? For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Jul 10 2017
My impression was that this text is supposed to match the color we use for the hostname. How do you know these are supposed to match, and that the icon is the source of truth rather than the text?
,
Jul 10 2017
I'm actually not sure; I haven't seen the mocks in a while. If the text color is supposed to match the hostname, then Mac has the opposite bug.
,
Jul 10 2017
Uff da. Definitely sounds like something isn't right here. +CC maxwalker
,
Jul 14 2017
The verbose text color should match the icon (as in all other states).
,
Jul 14 2017
Cool, so Mac is correct and Views is wrong.
,
Aug 2 2017
Screenshot for https://chromium-review.googlesource.com/c/599034 demonstrating that the colors are now correct in all situations.
,
Aug 2 2017
Also: secure and insecure in incognito, for good measure.
,
Aug 17 2017
Looks great. Thanks, Lucas and Peter!
,
Nov 10 2017
,
Dec 1 2017
,
Feb 18 2018
,
Feb 20 2018
Is this still an issue? I can't reproduce this
,
Feb 22 2018
I just checked on Windows and Chrome OS (http-login.badssl.com, latest Canary). The verbose text color is black. It should match the (i) icon's dark grey color.
,
Feb 22 2018
Awesome, thanks
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b0de26461d647fa94fe72c975797890e1ae7f80 commit 3b0de26461d647fa94fe72c975797890e1ae7f80 Author: Sarah Chan <spqchan@chromium.org> Date: Tue Mar 13 01:15:45 2018 [Views] Fix incorrect security chip color Currently, the security text color does not always match the icon. This CL fixes that by calculating the color like what was done in OmniboxViewMac. Bug: 740722 Change-Id: I693625a5b8db0b2400cfe4ab0c26f2421898d4bf Reviewed-on: https://chromium-review.googlesource.com/949449 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#542681} [modify] https://crrev.com/3b0de26461d647fa94fe72c975797890e1ae7f80/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/3b0de26461d647fa94fe72c975797890e1ae7f80/chrome/browser/ui/views/location_bar/location_bar_view.h [modify] https://crrev.com/3b0de26461d647fa94fe72c975797890e1ae7f80/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
,
Mar 14 2018
Verified the fix on Windows-10 and Ubuntu 14.04 using Chrome version #67.0.3370.0 as per the comment #0. Attaching screen shot for reference. Observed that verbose text colour is grey. Hence, the fix is working as expected. Adding the verified labels. Thanks...!!
,
Mar 14 2018
++ Able to reproduce the issue on chrome versions without fix.
,
Mar 14 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by lgar...@chromium.org
, Jul 10 20176.7 KB
6.7 KB View Download
60.1 KB
60.1 KB View Download