New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740722 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Verbose state for omnibox views should match icon color

Project Member Reported by lgar...@chromium.org, Jul 10 2017

Issue description

Chrome Version: 59
OS: Windows, Chrome OS

What steps will reproduce the problem?
(1) Visit http-login.badssl.com

What is the expected result?
The verbose text color matches the info icon

What happens instead?
The verbose text color is black

Please use labels and text to provide additional information.

spqchan@, could you triage?
For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Screenshots.

(Also, source: https://twitter.com/lgarron/status/884518366450339840)
Screen Shot 2017-07-10 at 14.57.19.png
6.7 KB View Download
DEWB9xbUMAEWlbN.jpg
60.1 KB View Download
My impression was that this text is supposed to match the color we use for the hostname.

How do you know these are supposed to match, and that the icon is the source of truth rather than the text?
I'm actually not sure; I haven't seen the mocks in a while.

If the text color is supposed to match the hostname, then Mac has the opposite bug.
Screen Shot 2017-07-10 at 15.31.10.png
13.7 KB View Download
Cc: maxwalker@chromium.org
Uff da.  Definitely sounds like something isn't right here.  +CC maxwalker
The verbose text color should match the icon (as in all other states).
Non-Touch-Colors.png
61.9 KB View Download
Summary: Verbose state for omnibox views should match icon color (was: Verbose state for omnibox views uses black text instead of gray)
Cool, so Mac is correct and Views is wrong.
Cc: spqc...@chromium.org
Owner: lgar...@chromium.org
Status: Started (was: Assigned)
Screenshot for https://chromium-review.googlesource.com/c/599034 demonstrating that the colors are now correct in all situations.
Screenshot from 2017-08-02 15:22:04.png
65.6 KB View Download
Also: secure and insecure in incognito, for good measure.
Screenshot from 2017-08-02 15:32:56.png
45.1 KB View Download
Looks great. Thanks, Lucas and Peter!
Labels: Hotlist-EnamelAndFriendsFixIt
Owner: ----
Status: Available (was: Started)
Labels: -Hotlist-EnamelAndFriendsFixIt
Is this still an issue? I can't reproduce this
I just checked on Windows and Chrome OS (http-login.badssl.com, latest Canary). The verbose text color is black. It should match the (i) icon's dark grey color.
Cc: -spqc...@chromium.org
Owner: spqc...@chromium.org
Status: Assigned (was: Available)
Awesome, thanks
Project Member

Comment 16 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b0de26461d647fa94fe72c975797890e1ae7f80

commit 3b0de26461d647fa94fe72c975797890e1ae7f80
Author: Sarah Chan <spqchan@chromium.org>
Date: Tue Mar 13 01:15:45 2018

[Views] Fix incorrect security chip color

Currently, the security text color does not always
match the icon. This CL fixes that by calculating the
color like what was done in OmniboxViewMac.

Bug:  740722 
Change-Id: I693625a5b8db0b2400cfe4ab0c26f2421898d4bf
Reviewed-on: https://chromium-review.googlesource.com/949449
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542681}
[modify] https://crrev.com/3b0de26461d647fa94fe72c975797890e1ae7f80/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/3b0de26461d647fa94fe72c975797890e1ae7f80/chrome/browser/ui/views/location_bar/location_bar_view.h
[modify] https://crrev.com/3b0de26461d647fa94fe72c975797890e1ae7f80/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Labels: TE-Verified-67.0.3370.0 TE-Verified-M67
Verified the fix on Windows-10 and Ubuntu 14.04 using Chrome version #67.0.3370.0 as per the comment #0.
Attaching screen shot for reference.
Observed that verbose text colour is grey.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
740722 CL Verif.png
181 KB View Download
++ Able to reproduce the issue on chrome versions without fix.
Status: Fixed (was: Assigned)

Sign in to add a comment