New issue
Advanced search Search tips

Issue 740714 link

Starred by 2 users
Status: Fixed
Owner:
donnd@chromium.org
Closed: Jul 2017
Cc:
twelling...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocking:
issue 676108



Sign in to add a comment

[TTS] Add proposed UKM signals

Project Member Reported by donnd@chromium.org, Jul 10 2017 
We've proposed writing signals to UKM for M61, but not all of them are being captured, and none are being written to UKM.

We need to:
A) write all our new Ranker v2 signals to UKM
B) change the existing ones to not be all-uppercase ( issue 736158 )
C) add "did-optin", "tap-duration", "was-cards-data-shown"

Comment 1 by donnd@chromium.org, Jul 10 2017

Blocking: 676108
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f630dbf6da1a090259f5998ee2a94d71c81b9c6c

commit f630dbf6da1a090259f5998ee2a94d71c81b9c6c
Author: Donn Denman <donnd@google.com>
Date: Wed Jul 19 21:43:53 2017

[TTS] Write UKM CS v2 features to UKM log.

Adds a new set of Ranker features to log via UKM
for Contextual Search.  The doc for these UKM CS V2
features is at go/ukm-cs-2.

Also adds some simple tests that the expected features
have actually been logged.

BUG= 740714 

Change-Id: I23542702737e4d9de30e0bed6ba433663e8dac02
Reviewed-on: https://chromium-review.googlesource.com/572235
Commit-Queue: Donn Denman <donnd@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488000}
[modify] https://crrev.com/f630dbf6da1a090259f5998ee2a94d71c81b9c6c/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java
[modify] https://crrev.com/f630dbf6da1a090259f5998ee2a94d71c81b9c6c/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchEntityHeuristic.java
[modify] https://crrev.com/f630dbf6da1a090259f5998ee2a94d71c81b9c6c/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
[modify] https://crrev.com/f630dbf6da1a090259f5998ee2a94d71c81b9c6c/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRankerLogger.java
[modify] https://crrev.com/f630dbf6da1a090259f5998ee2a94d71c81b9c6c/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRankerLoggerImpl.java
[modify] https://crrev.com/f630dbf6da1a090259f5998ee2a94d71c81b9c6c/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java
[modify] https://crrev.com/f630dbf6da1a090259f5998ee2a94d71c81b9c6c/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/TapDurationSuppression.java
[modify] https://crrev.com/f630dbf6da1a090259f5998ee2a94d71c81b9c6c/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/TapWordEdgeSuppression.java
[modify] https://crrev.com/f630dbf6da1a090259f5998ee2a94d71c81b9c6c/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/TapWordLengthSuppression.java
[modify] https://crrev.com/f630dbf6da1a090259f5998ee2a94d71c81b9c6c/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
[modify] https://crrev.com/f630dbf6da1a090259f5998ee2a94d71c81b9c6c/tools/metrics/ukm/ukm.xml

Comment 3 by donnd@chromium.org, Jul 19 2017

Status: Fixed (was: Assigned)
#1B was done in this CL: https://chromium-review.googlesource.com/568760
►

Sign in to add a comment