GTM (and therefore Chrome) doesn’t build with 10.13 SDK from Xcode 9 beta 3 |
||
Issue descriptionWe need to pick up https://github.com/google/google-toolbox-for-mac/commit/ec72a2bc500a716369c383837bffdc7d2a22855b because of this: ../../third_party/google_toolbox_for_mac/src/AppKit/GTMCarbonEvent.m:97:5: error: implicit declaration of function 'verify_noerr' is invalid in C99 [-Werror,-Wimplicit-function-declaration] verify_noerr(CreateEvent(kCFAllocatorDefault, inClass, kind, ^ ../../third_party/google_toolbox_for_mac/src/AppKit/GTMCarbonEvent.m:393:3: error: implicit declaration of function 'require' is invalid in C99 [-Werror,-Wimplicit-function-declaration] require(event, CantUseParams); ^ ../../third_party/google_toolbox_for_mac/src/AppKit/GTMCarbonEvent.m:393:18: error: use of undeclared identifier 'CantUseParams' require(event, CantUseParams); ^ ../../third_party/google_toolbox_for_mac/src/AppKit/GTMCarbonEvent.m:394:20: error: use of undeclared identifier 'CantUseParams' require(handler, CantUseParams); ^ ../../third_party/google_toolbox_for_mac/src/AppKit/GTMCarbonEvent.m:395:26: error: use of undeclared identifier 'CantUseParams' require([event event], CantUseParams); ^ ../../third_party/google_toolbox_for_mac/src/AppKit/GTMCarbonEvent.m:593:19: error: use of undeclared identifier 'CantCreateKey' require(newKey, CantCreateKey); ^ ../../third_party/google_toolbox_for_mac/src/AppKit/GTMCarbonEvent.m:594:3: error: implicit declaration of function 'require_noerr_action' is invalid in C99 [-Werror,-Wimplicit-function-declaration] require_noerr_action(RegisterEventHotKey((UInt32)keyCode, ^ ../../third_party/google_toolbox_for_mac/src/AppKit/GTMCarbonEvent.m:600:24: error: use of undeclared identifier 'CantRegisterHotKey' CantRegisterHotKey, newKey = nil); ^ ../../third_party/google_toolbox_for_mac/src/AppKit/GTMCarbonEvent.m:613:3: error: implicit declaration of function 'check' is invalid in C99 [-Werror,-Wimplicit-function-declaration] check([hotkeys_ containsObject:keyRef]); ^ 9 errors generated.
,
Jul 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b0d6d14ecc0b3d2302901efcb457868522790db commit 2b0d6d14ecc0b3d2302901efcb457868522790db Author: Mark Mentovai <mark@chromium.org> Date: Tue Jul 11 00:18:50 2017 Update GTM to ec72a2bc500a716369c383837bffdc7d2a22855b This is needed for 10.13 SDK compatibility. See https://github.com/google/google-toolbox-for-mac/commit/ec72a2bc500a716369c383837bffdc7d2a22855b. 2ef3625a9193 s/GTMAddressBook/GTMABAddressBook/ a86965088edd First pass removing all deprecated uses of GTM_IPHONE_USE_SENTEST 157a381522da Merge pull request #129 from thomasvl/sentest_cleanup 9656673748be Bump the pod version to do a release 857a3f0ac59d Merge pull request #131 from thomasvl/update 5207aee433c5 Change file type from UTF16 to ASCII cc2054645ca7 Merge pull request #134 from sergiocampama/type 94d4ccfc1589 Change include to import for GTMDefines ca53d4727a2a Merge pull request #135 from sergiocampama/copy 9822411a0fcb Remove trailing whitespaces e0fc2bad1e98 Merge pull request #136 from sergiocampama/white 89055f58cb50 Support for tvOS (#139) 4ae69e6f0b00 Fixed PodSpec for tvOS (#140) d49d04d53abe Added -Wreserved-id-macro and but exclude existing nonconforming macros (#141) d9d3b228b735 Avoid error from reserved macro name for GTMRegex.h 7ae58d8e92ef Provides a testing entitlements files c867eb4055d7 Add default_subspecs to help avoid testing code ended up in apps ec72a2bc500a 10.13 SDK (and iOS 11 equivalent) compatibility for GTM Bug: 740712 Change-Id: Ia795ff53e53c53067b560bcb9111063507ab2455 Reviewed-on: https://chromium-review.googlesource.com/565770 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#485459} [modify] https://crrev.com/2b0d6d14ecc0b3d2302901efcb457868522790db/DEPS
,
Jul 11 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by mark@chromium.org
, Jul 10 2017