telemetry_perf_tests not isolated on chromium.perf |
||||
Issue descriptiontelemetry_perf_tests are not being isolated by the Linux Builder on chromium.perf (proof is the lack of swarming targets in this step: https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FLinux_Builder%2F129779%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout) This is because the Linux Perf builder on chromium.perf isn't running any tests, due to bug 732463 The chromium recipe doesn't seem to be able to see cross master, so it doesn't know that the mojo linux bot wants to run tests which require a target to be isolated. I believe I can make a small hack to make this work for now, such that the builder isolates the isolate we want.
,
Jul 10 2017
Yes, that's what we want. Normally this would work fine, although technically it probably shouldn't. It's broken because Linux Perf isn't running any tests right now. I also thought about adding a Linux Builder to the fyi waterfall. That would work as well. If that's what you think is the better solution, I'm fine doing that.
,
Jul 10 2017
Here's a CL which is one way to implement this change: https://chromium-review.googlesource.com/c/565898/. I added a bit more to the description there.
,
Jul 10 2017
Re: #1 > Do we want to do this because we don't have a "Linux Builder" on the perf.fyi waterfall right now? My understanding is that we want to get the Mojo Linux builder on FYI working so that Mojo team can use it to get performance data from their FYI config, not to replace data from the downed "Linux Builder". Stephen, Ned, is that correct?
,
Jul 10 2017
I would rather add a Linux Builder to the FYI waterfall than cross masters between "sheriffed" and "fyi". It's not an intrinsically bad idea to trigger optional tests off of a normal builder but I think we're just not conceptually set up for such a thing at the moment.
,
Jul 10 2017
But I thought we'd been doing that for a long time already?
,
Jul 10 2017
If we were, I didn't know about it and would rather not do that, but I could perhaps be convinced otherwise. Generally speaking I'd expect every master to be independent and changes to one shouldn't affect others.
,
Jul 10 2017
+dtu, isn't one of the main ideas behind build-per-revision that other masters (specifically tryserver.chromium.perf) can pick up builds from chromium.perf master? It seems kinda silly to have so much hardware for doing builds and then request more hardware for building on FYI. In general I think it will be pretty rare that FYI needs a build config that the main chromium.perf doesn't have.
,
Jun 8 2018
Mojo Linux Perf Builder doesn't exist anymore. Closing. |
||||
►
Sign in to add a comment |
||||
Comment 1 by dpranke@chromium.org
, Jul 10 2017