[MD settings] chromeos input method options |
|||
Issue descriptionin chrome settings, languages, input methods some input methods may show an external link icon for options (for that input method). The makes for an inconsistent UI because the row ends up with two actions: enabling the input and going to the options. To address that, we could put a vertical separator bar between the two operations on the row. Or the UI can be changed in some other way (i.e. adding a separator is not the only choice that would fix it).
,
Aug 29 2017
SGTM!
,
Jun 9 2018
I think this just needs a
<div class="separator"></div>
before
<paper-icon-button-light class="icon-external"
hidden="[[!item.hasOptionsPage]]">
<button on-click="onInputMethodOptionsTap_"></button>
</paper-icon-button-light>
in chrome/browser/resources/settings/languages_page/languages_page.html
Oh, and the hidden="[[!item.hasOptionsPage]]" needs to be moved to an outer div. Something like
<div hidden="[[!item.hasOptionsPage]]">
<div class="separator"></div>
<paper-icon-button-light class="icon-external">
<button on-click="onInputMethodOptionsTap_"></button>
</paper-icon-button-light>
</div>
,
Jun 9 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by tbuck...@chromium.org
, Jul 10 2017