New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740686 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Polish notifications

Project Member Reported by khorimoto@chromium.org, Jul 10 2017

Issue description

Notifications need an icon, etc.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2d513f998f9bdd9ccc8ce1678aa3cce44633907

commit b2d513f998f9bdd9ccc8ce1678aa3cce44633907
Author: Regan Hsu <hsuregan@google.com>
Date: Fri Jul 14 17:27:19 2017

[CrOS] Add blue icon to nearby tether hotspot notification.

Allow tether notifications to display blue icons with
varing signal strength.

Bug:  740686 
Change-Id: I2e3477b899ece0a511270c82f48d52d44bfaf608
Reviewed-on: https://chromium-review.googlesource.com/564199
Commit-Queue: Regan Hsu <hsuregan@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486791}
[modify] https://crrev.com/b2d513f998f9bdd9ccc8ce1678aa3cce44633907/ash/system/network/network_icon.cc
[modify] https://crrev.com/b2d513f998f9bdd9ccc8ce1678aa3cce44633907/ash/system/network/network_icon.h
[modify] https://crrev.com/b2d513f998f9bdd9ccc8ce1678aa3cce44633907/chrome/browser/chromeos/net/DEPS
[modify] https://crrev.com/b2d513f998f9bdd9ccc8ce1678aa3cce44633907/chrome/browser/chromeos/net/tether_notification_presenter.cc
[modify] https://crrev.com/b2d513f998f9bdd9ccc8ce1678aa3cce44633907/chrome/browser/chromeos/net/tether_notification_presenter.h
[modify] https://crrev.com/b2d513f998f9bdd9ccc8ce1678aa3cce44633907/chrome/browser/chromeos/net/tether_notification_presenter_unittest.cc
[modify] https://crrev.com/b2d513f998f9bdd9ccc8ce1678aa3cce44633907/chromeos/components/tether/fake_notification_presenter.cc
[modify] https://crrev.com/b2d513f998f9bdd9ccc8ce1678aa3cce44633907/chromeos/components/tether/fake_notification_presenter.h
[modify] https://crrev.com/b2d513f998f9bdd9ccc8ce1678aa3cce44633907/chromeos/components/tether/host_scanner.cc
[modify] https://crrev.com/b2d513f998f9bdd9ccc8ce1678aa3cce44633907/chromeos/components/tether/notification_presenter.h

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7f2abe664058425d0d3ae4becaa61961e4d7e8a

commit b7f2abe664058425d0d3ae4becaa61961e4d7e8a
Author: Regan Hsu <hsuregan@google.com>
Date: Fri Jul 14 22:27:37 2017

[CrOS Tether] UI polishes for tether confirmation dialog.

The tether confirmation dialog now uses blue network icons specifically,
and includes more UI stylizations.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ice0c1ee283ea09918a5ca4ada044598ac4f4a15a

BUG= 740686 

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ice0c1ee283ea09918a5ca4ada044598ac4f4a15a
Reviewed-on: https://chromium-review.googlesource.com/555592
Commit-Queue: Regan Hsu <hsuregan@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486910}
[modify] https://crrev.com/b7f2abe664058425d0d3ae4becaa61961e4d7e8a/chrome/app/settings_strings.grdp
[modify] https://crrev.com/b7f2abe664058425d0d3ae4becaa61961e4d7e8a/chrome/browser/resources/settings/internet_page/tether_connection_dialog.html
[modify] https://crrev.com/b7f2abe664058425d0d3ae4becaa61961e4d7e8a/chrome/browser/resources/settings/internet_page/tether_connection_dialog.js
[modify] https://crrev.com/b7f2abe664058425d0d3ae4becaa61961e4d7e8a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Sign in to add a comment