New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 740671 link

Starred by 2 users
Status: Fixed
Owner:
█ lesliewatkins@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Cc:
█ jlklein@chromium.org
█ lesliewatkins@chromium.org
khorimoto@chromium.org
jhawkins@chromium.org
hansberry@chromium.org
█ jonmann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Add "Enable Bluetooth" Message to Quick Settings

Project Member Reported by khorimoto@chromium.org, Jul 10 2017 
Repro:
(0) Ensure that tethering is allowed (i.e., we have synced tether hosts, it is enabled by policy, etc).
(1) Disable Bluetooth. This should disable tethering.
(2) Open quick settings.

Expected:
Mobile section shows message indicating that the user can enable Bluetooth to look for mobile tether devices.

Actual:
Not yet displayed.

Comment 1 by khorimoto@chromium.org, Jul 19 2017

Status: Fixed (was: Started)
Fixed by https://codereview.chromium.org/2957043002.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/098beb35d0fabc714992b66a5431dbca376c7c80

commit 098beb35d0fabc714992b66a5431dbca376c7c80
Author: Leslie Watkins <lesliewatkins@chromium.org>
Date: Thu Jul 20 16:20:50 2017

Add a row in the network tray to inform users to turn Bluetooth on to enable Tether.

Rename TrayDetailsView::InfoLabel to TrayInfoLabel and moved it to its own file. It also now subclasses ActionableView instead of View, so it can be clickable. TrayInfoLabel::Delegate keeps track of whether or not the label is clickable, and handles clicks.

Reland of https://codereview.chromium.org/2957043002/

This reverts commit fc8ab64a4bd1d37a7eee1d50629750e79ba6553e.

Bug: 672263,  735642 ,  740671 
Change-Id: I7957bc934e01e226ee588939a21d1fc4afc0bdb3
Reviewed-on: https://chromium-review.googlesource.com/578142
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488263}
[modify] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/BUILD.gn
[modify] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/ash_strings.grd
[modify] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/system/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/system/network/network_icon.cc
[modify] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/system/network/network_list.cc
[modify] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/system/network/network_list.h
[modify] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/system/tray/tray_details_view.cc
[modify] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/system/tray/tray_details_view.h
[add] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/system/tray/tray_info_label.cc
[add] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/system/tray/tray_info_label.h
[add] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/system/tray/tray_info_label_unittest.cc
[modify] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/system/tray/tray_popup_item_style.cc
[modify] https://crrev.com/098beb35d0fabc714992b66a5431dbca376c7c80/ash/system/tray/tray_popup_item_style.h
►

Sign in to add a comment