New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740669 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Virtual Keyboard doesn't always show up when tapping the searchbox

Project Member Reported by newcomer@chromium.org, Jul 10 2017

Issue description

The search box view has two parts, the textfield and the white background of the searchbox.

When a tap event is received on the textfield the virtual keyboard summons as normal.

When a tap event is received on the white background (SearchBoxView::OnGestureEvent()) the virtual keyboard does not show up.

Steps to Repro:
Tap on the edges of the search box in maximize mode, the keyboard should show up but it does not.



 
Also in this bug:
Dismiss the virtual keyboard when the searchbox becomes inactive.
Current behavior: v keyboard shows up until the AppListView is dismissed regardless of searchbox focus.
Clearing the searchbox should not dismiss the keyboard
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee1e914346a3db5b7e0c59ac5ca31813a4631e84

commit ee1e914346a3db5b7e0c59ac5ca31813a4631e84
Author: Alex Newcomer <newcomer@chromium.org>
Date: Wed Jul 26 19:35:43 2017

cros: Virtual Keyboard behavior in the new launcher.

When the searchbox is active and the device is in tablet mode
the virtual keyboard will be shown.

Bug:  740669 
Change-Id: I25523b905ced2b5267f08bae56622aac6f8abc18
Reviewed-on: https://chromium-review.googlesource.com/576609
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489724}
[modify] https://crrev.com/ee1e914346a3db5b7e0c59ac5ca31813a4631e84/ui/app_list/BUILD.gn
[modify] https://crrev.com/ee1e914346a3db5b7e0c59ac5ca31813a4631e84/ui/app_list/DEPS
[modify] https://crrev.com/ee1e914346a3db5b7e0c59ac5ca31813a4631e84/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/ee1e914346a3db5b7e0c59ac5ca31813a4631e84/ui/app_list/views/app_list_view.h
[modify] https://crrev.com/ee1e914346a3db5b7e0c59ac5ca31813a4631e84/ui/app_list/views/search_box_view.cc
[modify] https://crrev.com/ee1e914346a3db5b7e0c59ac5ca31813a4631e84/ui/app_list/views/search_box_view.h

Status: Fixed (was: Available)
Labels: Merge-Request-61
Project Member

Comment 7 by sheriffbot@chromium.org, Jul 27 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 31 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b24785517b115262f7113f09598fbcfef252deaf

commit b24785517b115262f7113f09598fbcfef252deaf
Author: Maajid <maajid@chromium.org>
Date: Mon Jul 31 21:07:13 2017

cros: Virtual Keyboard behavior in the new launcher.

When the searchbox is active and the device is in tablet mode
the virtual keyboard will be shown.

TBR=newcomer@chromium.org

(cherry picked from commit ee1e914346a3db5b7e0c59ac5ca31813a4631e84)

Bug:  740669 
Change-Id: I25523b905ced2b5267f08bae56622aac6f8abc18
Reviewed-on: https://chromium-review.googlesource.com/576609
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489724}
Reviewed-on: https://chromium-review.googlesource.com/595031
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#181}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/b24785517b115262f7113f09598fbcfef252deaf/ui/app_list/BUILD.gn
[modify] https://crrev.com/b24785517b115262f7113f09598fbcfef252deaf/ui/app_list/DEPS
[modify] https://crrev.com/b24785517b115262f7113f09598fbcfef252deaf/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/b24785517b115262f7113f09598fbcfef252deaf/ui/app_list/views/app_list_view.h
[modify] https://crrev.com/b24785517b115262f7113f09598fbcfef252deaf/ui/app_list/views/search_box_view.cc
[modify] https://crrev.com/b24785517b115262f7113f09598fbcfef252deaf/ui/app_list/views/search_box_view.h

Cc: dhadd...@chromium.org mkarkada@chromium.org
Status: Verified (was: Fixed)
Verified on Chrome OS 9824.0.0, 62.0.3176.0 dev build.
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 and M62.
Project Member

Comment 11 by sheriffbot@chromium.org, Sep 11 2017

Cc: keta...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by sheriffbot@chromium.org, Sep 15 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-61

Sign in to add a comment