New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740663 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

color: Move "force color profile" flag to display::

Project Member Reported by ccameron@chromium.org, Jul 10 2017

Issue description

We implemented "force color profile" in ui::ICCProfile because it was needed there to respect forced color profiles in non-color-correct mode.

Now that all tests that are affected by this have been moved to color correct mode, we can move the flag to a more reasonable location, namely display::Display (like force device scale factor).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4f5fdaff26071bf65dfe22683b6826942376c64

commit a4f5fdaff26071bf65dfe22683b6826942376c64
Author: Christopher Cameron <ccameron@chromium.org>
Date: Wed Jul 12 07:57:51 2017

Move --force-color-profile to display::Display

This matches the behavior of --force-device-scale-factor.

Move the checks for "is the color profile forced" from
the implementation of ICCProfile::FromBestMonitor to the
call sites to avoid layering violations.

Bug:  740663 
Change-Id: I8f37b8b5ca6300465a1e7e0132e587378805a813
Reviewed-on: https://chromium-review.googlesource.com/565763
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485894}
[modify] https://crrev.com/a4f5fdaff26071bf65dfe22683b6826942376c64/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/a4f5fdaff26071bf65dfe22683b6826942376c64/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/a4f5fdaff26071bf65dfe22683b6826942376c64/content/public/test/browser_test_base.cc
[modify] https://crrev.com/a4f5fdaff26071bf65dfe22683b6826942376c64/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/a4f5fdaff26071bf65dfe22683b6826942376c64/content/test/layouttest_support.cc
[modify] https://crrev.com/a4f5fdaff26071bf65dfe22683b6826942376c64/ui/android/display_android_manager.cc
[modify] https://crrev.com/a4f5fdaff26071bf65dfe22683b6826942376c64/ui/display/display.cc
[modify] https://crrev.com/a4f5fdaff26071bf65dfe22683b6826942376c64/ui/display/display.h
[modify] https://crrev.com/a4f5fdaff26071bf65dfe22683b6826942376c64/ui/display/display_switches.cc
[modify] https://crrev.com/a4f5fdaff26071bf65dfe22683b6826942376c64/ui/display/display_switches.h
[modify] https://crrev.com/a4f5fdaff26071bf65dfe22683b6826942376c64/ui/display/mac/screen_mac.mm
[modify] https://crrev.com/a4f5fdaff26071bf65dfe22683b6826942376c64/ui/display/win/screen_win.cc
[modify] https://crrev.com/a4f5fdaff26071bf65dfe22683b6826942376c64/ui/gfx/color_space_switches.cc
[modify] https://crrev.com/a4f5fdaff26071bf65dfe22683b6826942376c64/ui/gfx/color_space_switches.h
[modify] https://crrev.com/a4f5fdaff26071bf65dfe22683b6826942376c64/ui/gfx/icc_profile.cc
[modify] https://crrev.com/a4f5fdaff26071bf65dfe22683b6826942376c64/ui/gfx/icc_profile.h
[modify] https://crrev.com/a4f5fdaff26071bf65dfe22683b6826942376c64/ui/gfx/icc_profile_mac.mm
[modify] https://crrev.com/a4f5fdaff26071bf65dfe22683b6826942376c64/ui/gfx/icc_profile_win.cc
[modify] https://crrev.com/a4f5fdaff26071bf65dfe22683b6826942376c64/ui/gfx/icc_profile_x11.cc
[modify] https://crrev.com/a4f5fdaff26071bf65dfe22683b6826942376c64/ui/gfx/test/icc_profiles.cc
[modify] https://crrev.com/a4f5fdaff26071bf65dfe22683b6826942376c64/ui/gfx/test/icc_profiles.h
[modify] https://crrev.com/a4f5fdaff26071bf65dfe22683b6826942376c64/ui/views/widget/desktop_aura/desktop_screen_x11.cc

Status: Fixed (was: Assigned)

Sign in to add a comment