New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740657 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Resigned
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Chromium roll into WebRTC is blocked on android lint failures.

Project Member Reported by ehmaldonado@chromium.org, Jul 10 2017

Issue description

Chromium roll into WebRTC is blocked on android lint failures.

See https://codereview.webrtc.org/2978513002/ for example.

The compile step fails with:

FAILED: gen/webrtc/sdk/android/libjingle_peerconnection_android_unittest__apk__java__lint/result.xml gen/webrtc/sdk/android/libjingle_peerconnection_android_unittest__apk__java__lint/config.xml 
python ../../build/android/gyp/lint.py --lint-path=../../third_party/android_tools/sdk/tools-lint/bin/lint --cache-dir android_lint_cache --platform-xml-path ../../third_party/android_tools/sdk/platform-tools/api/api-versions.xml --android-sdk-version=25 --depfile gen/webrtc/sdk/android/libjingle_peerconnection_android_unittest__apk__java__lint.d --config-path ../../tools_webrtc/android/suppressions.xml --manifest-path gen/webrtc/sdk/android/libjingle_peerconnection_android_unittest__apk_manifest/AndroidManifest.xml --product-dir=. --processed-config-path gen/webrtc/sdk/android/libjingle_peerconnection_android_unittest__apk__java__lint/config.xml --result-path gen/webrtc/sdk/android/libjingle_peerconnection_android_unittest__apk__java__lint/result.xml --java-sources-file=gen/webrtc/sdk/android/libjingle_peerconnection_android_unittest__apk/libjingle_peerconnection_android_unittest__apk.sources --jar-path gen/webrtc/sdk/android/libjingle_peerconnection_android_unittest__apk__java__compile_java.javac.jar --classpath=@FileArg\(gen/webrtc/sdk/android/libjingle_peerconnection_android_unittest__apk.build_config:javac:interface_classpath\) --resource-sources=@FileArg\(gen/webrtc/sdk/android/libjingle_peerconnection_android_unittest__apk.build_config:deps_info:owned_resources_dirs\) --resource-sources=@FileArg\(gen/webrtc/sdk/android/libjingle_peerconnection_android_unittest__apk.build_config:deps_info:owned_resources_zips\) --srcjars=@FileArg\(gen/webrtc/sdk/android/libjingle_peerconnection_android_unittest__apk.build_config:gradle:bundled_srcjars\) --can-fail-build

AndroidManifest.xml:41 Attribute is missing the Android namespace prefix: MissingPrefix [warning]
        chromium-junit4="true"
        ~~~~~~~~~~~~~~~~~~~~~~
Traceback (most recent call last):
  File "../../build/android/gyp/lint.py", line 196, in _OnStaleMd5
    stderr_filter=stderr_filter)
  File "/b/c/b/android_arm64_rel/src/build/android/gyp/util/build_utils.py", line 179, in CheckOutput
    raise CalledProcessError(cwd, args, stdout + stderr)
CalledProcessError: Command failed: ( cd /b/c/b/android_arm64_rel/src; third_party/android_tools/sdk/tools-lint/bin/lint -Werror --exitcode --showall --xml out/Release/gen/webrtc/sdk/android/libjingle_peerconnection_android_unittest__apk__java__lint/result.xml --classpath out/Release/gen/webrtc/sdk/android/libjingle_peerconnection_android_unittest__apk__java__compile_java.javac.jar --config out/Release/gen/webrtc/sdk/android/libjingle_peerconnection_android_unittest__apk__java__lint/config.xml --libraries out/Release/lib.java/base/base_java.interface.jar:out/Release/lib.java/base/base_java_test_support.interface.jar:out/Release/lib.java/third_party/android_support_test_runner/rules_java.interface.jar:out/Release/lib.java/third_party/android_support_test_runner/runner-0.5-release-no-dep.interface.jar:out/Release/lib.java/third_party/junit/junit.interface.jar:out/Release/lib.java/webrtc/rtc_base/base_java.interface.jar:out/Release/lib.java/webrtc/sdk/android/libjingle_peerconnection_java.interface.jar:out/Release/lib.java/webrtc/sdk/android/libjingle_peerconnection_metrics_default_java.interface.jar:out/Release/lib.java/testing/android/broker/broker_java.interface.jar --sources /tmp/tmpk93Y8q/SRC_ROOT1 /tmp/tmpk93Y8q/SRC_ROOT2 )

Scanning SRC_ROOT2: ..................
Scanning SRC_ROOT2 (Phase 2): 
Wrote XML report to file:///b/c/b/android_arm64_rel/src/out/Release/gen/webrtc/sdk/android/libjingle_peerconnection_android_unittest__apk__java__lint/result.xml
Lint found 1 error

Unexpected failure during lint analysis of RendererCommonTest.java (this is a bug in lint or one of the libraries it depends on)
AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761)

Unexpected failure during lint analysis of PeerConnectionTest.java (this is a bug in lint or one of the libraries it depends on)
AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761)

Unexpected failure during lint analysis of FileVideoCapturerTest.java (this is a bug in lint or one of the libraries it depends on)
AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761)

Unexpected failure during lint analysis of VideoFileRendererTest.java (this is a bug in lint or one of the libraries it depends on)
AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761)

Unexpected failure during lint analysis of HardwareVideoDecoderTest.java (this is a bug in lint or one of the libraries it depends on)
AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761)


AndroidManifest.xml:41 Attribute is missing the Android namespace prefix: MissingPrefix [warning]
        chromium-junit4="true"
        ~~~~~~~~~~~~~~~~~~~~~~

Lint found 1 new issues.
 - For full explanation, please refer to out/Release/gen/webrtc/sdk/android/libjingle_peerconnection_android_unittest__apk__java__lint/result.xml
 - For more information about lint and how to fix lint issues, please refer to https://chromium.googlesource.com/chromium/src/+/master/build/android/docs/lint.md

Traceback (most recent call last):
  File "../../build/android/gyp/lint.py", line 385, in <module>
    sys.exit(main())
  File "../../build/android/gyp/lint.py", line 381, in main
    depfile_deps=classpath)
  File "/b/c/b/android_arm64_rel/src/build/android/gyp/util/build_utils.py", line 592, in CallAndWriteDepfileIfStale
    pass_changes=True)
  File "/b/c/b/android_arm64_rel/src/build/android/gyp/util/md5_check.py", line 87, in CallAndRecordIfStale
    function(*args)
  File "/b/c/b/android_arm64_rel/src/build/android/gyp/util/build_utils.py", line 575, in on_stale_md5
    function(*args)
  File "../../build/android/gyp/lint.py", line 376, in <lambda>
    silent=args.silent),
  File "../../build/android/gyp/lint.py", line 245, in _OnStaleMd5
    raise Exception('Lint failed.')
Exception: Lint failed.

 
Cc: mbonadei@chromium.org boliu@chromium.org agrieve@chromium.org
Owner: ingem...@opera.com
Ingemar: Can you help us take a look, please?

I think it's related to your change in https://chromium.googlesource.com/chromium/src/build/+/6ada47bc7950dd870a3a82458790a0cc0b7ba649

Comment 2 by ingem...@opera.com, Jul 11 2017

Looks related for sure, I'll take a look at it!
Cc: sakal@chromium.org

Comment 4 Deleted

Comment 5 by ingem...@opera.com, Jul 11 2017

I probably used the wrong BUG label (didn't now it was supposed to be prefixed with 'webrtc:').

Landed https://chromium.googlesource.com/external/webrtc/+/87b6ddb5610df73400202481233a60d6fc601cae.
Status: Fixed (was: Untriaged)
Thanks!

Sign in to add a comment