New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740653 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

some third party device fail bindService if intent contains a parceable

Project Member Reported by boliu@chromium.org, Jul 10 2017

Issue description

Going to partially revert https://codereview.chromium.org/2756053002/

More context, including affected device in internal b/62529164
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dc289004d2efb78d33d1e1216383fa8d9a1f968

commit 5dc289004d2efb78d33d1e1216383fa8d9a1f968
Author: Bo Liu <boliu@chromium.org>
Date: Mon Jul 10 23:46:01 2017

android: LinkerParams no longer Parceable

This is partial revert of r457679. Some old thirdparty android devices
do not deal well with bindService intent with a Parceable. So make
LinkerParams explicitly set fields in a Bundle rather than pass it as a
Parceable.

BUG= 740653 

Change-Id: I0ad409a20c638ec4ff91c4331a189aee381edf7b
Reviewed-on: https://chromium-review.googlesource.com/565165
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Bo Liu <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485448}
[modify] https://crrev.com/5dc289004d2efb78d33d1e1216383fa8d9a1f968/content/public/android/java/src/org/chromium/content/app/ChromiumLinkerParams.java
[modify] https://crrev.com/5dc289004d2efb78d33d1e1216383fa8d9a1f968/content/public/android/java/src/org/chromium/content/app/ContentChildProcessServiceDelegate.java
[modify] https://crrev.com/5dc289004d2efb78d33d1e1216383fa8d9a1f968/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java
[modify] https://crrev.com/5dc289004d2efb78d33d1e1216383fa8d9a1f968/content/public/android/java/src/org/chromium/content/browser/ContentChildProcessConstants.java

Comment 2 by boliu@chromium.org, Jul 10 2017

Status: Fixed (was: Untriaged)

Sign in to add a comment