New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740644 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

ChildProcessLauncherTest#testPendingSpawnQueue is flaky

Project Member Reported by jcivelli@chromium.org, Jul 10 2017

Issue description

ChildProcessLauncherTest#testPendingSpawnQueue sometimes fails:

 detected failure in org.chromium.content.browser.ChildProcessLauncherTest#testPendingSpawnQueue. raw output:
I   68.939s run_tests_on_device(06cfe2330074d3a5)    INSTRUMENTATION_STATUS: numtests=1
I   68.939s run_tests_on_device(06cfe2330074d3a5)    INSTRUMENTATION_STATUS: stream=
I   68.939s run_tests_on_device(06cfe2330074d3a5)    org.chromium.content.browser.ChildProcessLauncherTest:
I   68.939s run_tests_on_device(06cfe2330074d3a5)    INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
I   68.939s run_tests_on_device(06cfe2330074d3a5)    INSTRUMENTATION_STATUS: test=testPendingSpawnQueue
I   68.939s run_tests_on_device(06cfe2330074d3a5)    INSTRUMENTATION_STATUS: class=org.chromium.content.browser.ChildProcessLauncherTest
I   68.939s run_tests_on_device(06cfe2330074d3a5)    INSTRUMENTATION_STATUS: current=1
I   68.939s run_tests_on_device(06cfe2330074d3a5)    INSTRUMENTATION_STATUS_CODE: 1
I   68.939s run_tests_on_device(06cfe2330074d3a5)    INSTRUMENTATION_STATUS: numtests=1
I   68.939s run_tests_on_device(06cfe2330074d3a5)    INSTRUMENTATION_STATUS: stream=
I   68.939s run_tests_on_device(06cfe2330074d3a5)    Error in testPendingSpawnQueue(org.chromium.content.browser.ChildProcessLauncherTest):
I   68.939s run_tests_on_device(06cfe2330074d3a5)    java.lang.NullPointerException: Attempt to invoke interface method 'void org.chromium.base.process_launcher.IChildProcessService.crashIntentionallyForTesting()' on a null object reference
I   68.939s run_tests_on_device(06cfe2330074d3a5)    	at org.chromium.content.browser.ChildProcessConnection.crashServiceForTesting(ChildProcessConnection.java:614)
I   68.939s run_tests_on_device(06cfe2330074d3a5)    	at org.chromium.content.browser.ChildProcessLauncherTest.testPendingSpawnQueue(ChildProcessLauncherTest.java:520)
I   68.939s run_tests_on_device(06cfe2330074d3a5)    	at java.lang.reflect.Method.invoke(Native Method)
I   68.939s run_tests_on_device(06cfe2330074d3a5)    	at java.lang.reflect.Method.invoke(Method.java:372)
I   68.939s run_tests_on_device(06cfe2330074d3a5)    	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
I   68.939s run_tests_on_device(06cfe2330074d3a5)    	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
I   68.939s run_tests_on_device(06cfe2330074d3a5)    	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
I   68.939s run_tests_on_device(06cfe2330074d3a5)    	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
I   68.939s run_tests_on_device(06cfe2330074d3a5)    	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
I   68.939s run_tests_on_device(06cfe2330074d3a5)    	at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37)
I   68.939s run_tests_on_device(06cfe2330074d3a5)    	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
I   68.939s run_tests_on_device(06cfe2330074d3a5)    	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
I   68.939s run_tests_on_device(06cfe2330074d3a5)    	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:135)
I   68.940s run_tests_on_device(06cfe2330074d3a5)    	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:36)
I   68.940s run_tests_on_device(06cfe2330074d3a5)    	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
I   68.940s run_tests_on_device(06cfe2330074d3a5)    	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
I   68.940s run_tests_on_device(06cfe2330074d3a5)    	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
I   68.940s run_tests_on_device(06cfe2330074d3a5)    	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
I   68.940s run_tests_on_device(06cfe2330074d3a5)    	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
I   68.940s run_tests_on_device(06cfe2330074d3a5)    	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
I   68.940s run_tests_on_device(06cfe2330074d3a5)    	at org.junit.runners.Suite.runChild(Suite.java:128)
I   68.940s run_tests_on_device(06cfe2330074d3a5)    	at org.junit.runners.Suite.runChild(Suite.java:27)
I   68.940s run_tests_on_device(06cfe2330074d3a5)    	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
I   68.940s run_tests_on_device(06cfe2330074d3a5)    	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
I   68.940s run_tests_on_device(06cfe2330074d3a5)    	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
I   68.940s run_tests_on_device(06cfe2330074d3a5)    	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
I   68.940s run_tests_on_device(06cfe2330074d3a5)    	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
I   68.940s run_tests_on_device(06cfe2330074d3a5)    	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
I   68.940s run_tests_on_device(06cfe2330074d3a5)    	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
I   68.940s run_tests_on_device(06cfe2330074d3a5)    	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
I   68.940s run_tests_on_device(06cfe2330074d3a5)    	at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
I   68.940s run_tests_on_device(06cfe2330074d3a5)    	at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
I   68.940s run_tests_on_device(06cfe2330074d3a5)    	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)
I   68.940s run_tests_on_device(06cfe2330074d3a5)    
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/facc6aef16671e73530e204574efda3ac89f5007

commit facc6aef16671e73530e204574efda3ac89f5007
Author: Jay Civelli <jcivelli@google.com>
Date: Mon Jul 10 21:49:12 2017

Fix flakyness in ChildProcessLauncherTest.testPendingSpawnQueue

The ChildProcessLauncherTest.testPendingSpawnQueue test accesses a
service without waiting for it to be bound.
In some cases it seemed it would be accessed before it was bound, the
IBinder interface was not set and we would get a NPE calling
crashServiceForTesting on it.

Bug:  740644 
Change-Id: If099fde3042cc0307366384ef8adf0af003ce1cf
Reviewed-on: https://chromium-review.googlesource.com/565009
Reviewed-by: Bo Liu <boliu@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485409}
[modify] https://crrev.com/facc6aef16671e73530e204574efda3ac89f5007/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java

Status: Fixed (was: Untriaged)

Sign in to add a comment