New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740641 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug



Sign in to add a comment

[Findit] Pubsub swarmingpush is not working

Project Member Reported by lijeffrey@chromium.org, Jul 10 2017

Issue description

/pubsub/swarmingpush returning HTTP 400 instead of 200
 
Cc: -chanli@chromium.org
Owner: chanli@chromium.org
Summary: [Findit] Pubsub swarmingpush is not working (was: [Findit] Flake Analyzer - "could not resolve arguments for waterfall.update_analysis_with_flake_info_pipeline")
Assigning to Chan as it seems pubsub notifications aren't working causing flake analyses to be stuck in "running" even though the swarming tasks are already completed
Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a7921db6d0e439961c19620f946a553474231897

commit a7921db6d0e439961c19620f946a553474231897
Author: Chan <chanli@chromium.org>
Date: Tue Jul 11 09:45:51 2017

[Findit] Use the correct config for swarming push.

And if token is expired, return 200 to pubsub but don't use the result.

Bug:  740641 
Change-Id: I00b7b20a50421ef827819b96c32e04d5f050326d
Reviewed-on: https://chromium-review.googlesource.com/566085
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/a7921db6d0e439961c19620f946a553474231897/appengine/findit/handlers/test/config_test.py
[modify] https://crrev.com/a7921db6d0e439961c19620f946a553474231897/appengine/findit/handlers/test/try_job_push_test.py
[modify] https://crrev.com/a7921db6d0e439961c19620f946a553474231897/appengine/findit/handlers/test/swarming_push_test.py
[modify] https://crrev.com/a7921db6d0e439961c19620f946a553474231897/appengine/findit/handlers/try_job_push.py
[modify] https://crrev.com/a7921db6d0e439961c19620f946a553474231897/appengine/findit/gae_libs/token.py
[modify] https://crrev.com/a7921db6d0e439961c19620f946a553474231897/appengine/findit/handlers/test/change_auto_revert_setting_test.py
[modify] https://crrev.com/a7921db6d0e439961c19620f946a553474231897/appengine/findit/handlers/test/check_duplicate_failures_test.py
[modify] https://crrev.com/a7921db6d0e439961c19620f946a553474231897/appengine/findit/gae_libs/test/token_test.py
[modify] https://crrev.com/a7921db6d0e439961c19620f946a553474231897/appengine/findit/handlers/flake/test/analyze_regression_range_test.py
[modify] https://crrev.com/a7921db6d0e439961c19620f946a553474231897/appengine/findit/handlers/test/triage_suspected_cl_test.py
[modify] https://crrev.com/a7921db6d0e439961c19620f946a553474231897/appengine/findit/handlers/test/help_triage_test.py
[modify] https://crrev.com/a7921db6d0e439961c19620f946a553474231897/appengine/findit/handlers/swarming_push.py
[modify] https://crrev.com/a7921db6d0e439961c19620f946a553474231897/appengine/findit/handlers/flake/test/check_flake_test.py
[modify] https://crrev.com/a7921db6d0e439961c19620f946a553474231897/appengine/findit/model/wf_config.py
[modify] https://crrev.com/a7921db6d0e439961c19620f946a553474231897/appengine/findit/handlers/test/build_failure_test.py
[modify] https://crrev.com/a7921db6d0e439961c19620f946a553474231897/appengine/findit/handlers/flake/test/triage_flake_analysis_test.py

Comment 4 by chanli@chromium.org, Jul 13 2017

Status: Fixed (was: Assigned)

Sign in to add a comment