New issue
Advanced search Search tips

Issue 740614 link

Starred by 1 user
Status: Fixed
Owner:
hanxi@chromium.org
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Killing WebAPK makes notifications no longer work

Project Member Reported by pkotw...@chromium.org, Jul 10 2017 
Repro steps:
1) Open WebAPK for https://tests.peter.sh/notification-generator/ in split screen along with Android Settings
2) Use the WebAPK to display a notification by tapping the "Display the notification" <button>
3) In the "Android Settings" split, kill the "Notifications" WebAPK
4) Tap the "Display the notification" button again

Expected:
Notification is shown
Actual:
Notification is not shown

Comment 1 by pkotw...@chromium.org, Jul 10 2017

Owner: hanxi@chromium.org
Status: Assigned (was: Untriaged)
Assigning to you Xi. I think that https://codereview.chromium.org/2974573002/ has a similar bug

Comment 2 by hanxi@chromium.org, Jul 19 2017

Status: Started (was: Assigned)
I fix this bug in CL: https://codereview.chromium.org/2974573002/ when refactoring the WebApkServiceConnecionManager.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb0b8d2f550e397f6c609273d4e4ad9a9e440705

commit fb0b8d2f550e397f6c609273d4e4ad9a9e440705
Author: hanxi <hanxi@chromium.org>
Date: Tue Jul 25 21:54:11 2017

Refactor WebApkServiceConnectionManager.

This is the 2/3 patch of fixing bug "The WebApkService shouldn't be shared
between different browsers".

In this CL, we did the following things:
1) refactor WebApkServiceConnectionManager to connect to any kind of services.
2) introduce WebApkServiceClient and WebApkIdentityServiceClient that manages
   communication between Chrome and WebAPK service/WebAPK Identity service respectively.

The refactoring of WebApkServiceConnectionManager also fixes notification issue
reported in  crbug.com/740614 .

BUG= 720077 , 740614 
TBR=peter@chromium.org

Review-Url: https://codereview.chromium.org/2974573002
Cr-Commit-Position: refs/heads/master@{#489454}

[modify] https://crrev.com/fb0b8d2f550e397f6c609273d4e4ad9a9e440705/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java
[modify] https://crrev.com/fb0b8d2f550e397f6c609273d4e4ad9a9e440705/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
[rename] https://crrev.com/fb0b8d2f550e397f6c609273d4e4ad9a9e440705/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkServiceClient.java
[modify] https://crrev.com/fb0b8d2f550e397f6c609273d4e4ad9a9e440705/chrome/android/java_sources.gni
[modify] https://crrev.com/fb0b8d2f550e397f6c609273d4e4ad9a9e440705/chrome/android/webapk/libs/client/BUILD.gn
[modify] https://crrev.com/fb0b8d2f550e397f6c609273d4e4ad9a9e440705/chrome/android/webapk/libs/client/junit/DEPS
[add] https://crrev.com/fb0b8d2f550e397f6c609273d4e4ad9a9e440705/chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkIdentityServiceClientTest.java
[modify] https://crrev.com/fb0b8d2f550e397f6c609273d4e4ad9a9e440705/chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkServiceConnectionManagerTest.java
[add] https://crrev.com/fb0b8d2f550e397f6c609273d4e4ad9a9e440705/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkIdentityServiceClient.java
[modify] https://crrev.com/fb0b8d2f550e397f6c609273d4e4ad9a9e440705/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkServiceConnectionManager.java

Comment 4 by hanxi@chromium.org, Aug 11 2017

Status: Fixed (was: Started)
►

Sign in to add a comment