New issue
Advanced search Search tips

Issue 740613 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix debugd autotests after migration to Chrome DBus API

Project Member Reported by ecgh@chromium.org, Jul 10 2017

Issue description

 Issue 705051  migrated debugd from dbus-c++ to Chrome DBus API. As a result debugd autotests can no longer rely on introspection and need to provide method signatures.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/de5ceb1fc086eb58bf2466dd6ea9c0452645f496

commit de5ceb1fc086eb58bf2466dd6ea9c0452645f496
Author: Edward Hill <ecgh@chromium.org>
Date: Wed Jul 12 00:48:03 2017

Add DBus method signatures to fix debugd autotests

As a result of migration from dbus-c++ to Chrome DBus API, debugd
autotests can no longer rely on introspection and need to provide
method signatures.

BUG= chromium:740613 
TEST=DumpDebugLogs/GetRoutes/Ping/TracePath tests pass on betty VM

Change-Id: I9cc96d1e0c794372a77d3b83d0f2c04e78e3a3c0
Reviewed-on: https://chromium-review.googlesource.com/565068
Commit-Ready: Edward Hill <ecgh@chromium.org>
Tested-by: Edward Hill <ecgh@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/de5ceb1fc086eb58bf2466dd6ea9c0452645f496/client/site_tests/platform_DebugDaemonPing/platform_DebugDaemonPing.py
[modify] https://crrev.com/de5ceb1fc086eb58bf2466dd6ea9c0452645f496/client/site_tests/platform_DebugDaemonTracePath/platform_DebugDaemonTracePath.py
[modify] https://crrev.com/de5ceb1fc086eb58bf2466dd6ea9c0452645f496/client/site_tests/platform_DebugDaemonGetRoutes/platform_DebugDaemonGetRoutes.py
[modify] https://crrev.com/de5ceb1fc086eb58bf2466dd6ea9c0452645f496/client/site_tests/platform_DebugDaemonDumpDebugLogs/platform_DebugDaemonDumpDebugLogs.py

Comment 2 by ecgh@chromium.org, Jul 12 2017

Status: Fixed (was: Started)

Sign in to add a comment