New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740612 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Email to this user bounced
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Add a flag to prevent changes to workers_ after JoinForTesting is called

Project Member Reported by jeffreyhe@google.com, Jul 10 2017

Issue description

In SchedulerWorkerPoolImpl::JoinForTesting(), a copy of workers_ is created before SchedulerWorker::JoinForTesting() is called on individual workers. 

It is assumed that workers_ does not change after the copy is created (i.e. no workers are created & added to workers_ and no workers_ are removed).

Instead, there should be a flag that is set within SchedulerWorkerPoolImpl::JoinForTesting() that verifies that no changes are made to workers_. 
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 11 2017

Labels: Hotlist-Google
Status: WontFix (was: Assigned)
Another approach will be taken to fix JoinForTesting when |workers_| is dynamic.

In particular, JoinForTesting will keep calling JoinForTesting until |workers_| is empty.

Sign in to add a comment