Add a flag to prevent changes to workers_ after JoinForTesting is called |
||
Issue descriptionIn SchedulerWorkerPoolImpl::JoinForTesting(), a copy of workers_ is created before SchedulerWorker::JoinForTesting() is called on individual workers. It is assumed that workers_ does not change after the copy is created (i.e. no workers are created & added to workers_ and no workers_ are removed). Instead, there should be a flag that is set within SchedulerWorkerPoolImpl::JoinForTesting() that verifies that no changes are made to workers_.
,
Jul 12 2017
Another approach will be taken to fix JoinForTesting when |workers_| is dynamic. In particular, JoinForTesting will keep calling JoinForTesting until |workers_| is empty. |
||
►
Sign in to add a comment |
||
Comment 1 by sheriffbot@chromium.org
, Jul 11 2017