Can I remove the UMA "MobileFirstTextInOmnibox"? Removing would clean the code and make implementing https://docs.google.com/document/d/1pWfwHEeCNeWgkDjawJiDoEf93gkDV9usINcYDyXvwcY/edit#heading=h.sku52p315l4d a bit simpler. Explanation of what it's supposed to record at https://bugs.chromium.org/p/chromium/issues/detail?id=178932#c26 As far as I know this metric only exists on iOS, and right now it's not working in M61.
This sounds good to me but I'm adding Rohit to make sure.
I'm fine with removing this metric.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7774ffbffc14fa93b82ef261a98d923b69db3209 commit 7774ffbffc14fa93b82ef261a98d923b69db3209 Author: Jean-François Geyelin <jif@chromium.org> Date: Wed Jul 12 16:25:37 2017 [iOS] Prepare for the support of InputAssistantItems on iPad. This CL cleans the Keyboard Accessory View (KAV) situation for the web toolbar to support InputAssistantItems on iPad (1). In particular, this CL: - Removes keyboard_accessory_view.*. Now only new_keyboard_accessory_view.* is used. - Removes HardwareKeyboardWatcher because it only works when there is a KAV (crbug.com/740898). - Removes |-locationBarChanged| because it would only be used to record MobileFirstTextInOmnibox ( crbug.com/740611 ). - Removes the |_keyboardAccessoryView| ivar. It was used when the KAV was not laid out with auto layout and had multiple modes. (1) https://docs.google.com/document/d/1pWfwHEeCNeWgkDjawJiDoEf93gkDV9usINcYDyXvwcY/edit#heading=h.sku52p315l4d Bug: 738106 , 708341 , 740611 Change-Id: If6e509de3e6d57f0347b3e355b91af16bd055adb Reviewed-on: https://chromium-review.googlesource.com/567087 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Jean-François Geyelin <jif@chromium.org> Cr-Commit-Position: refs/heads/master@{#485989} [modify] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/chrome/browser/ui/keyboard/BUILD.gn [delete] https://crrev.com/f6a6833d464b96fbc7cc27abe41e411487779ba2/ios/chrome/browser/ui/keyboard/hardware_keyboard_watcher.h [delete] https://crrev.com/f6a6833d464b96fbc7cc27abe41e411487779ba2/ios/chrome/browser/ui/keyboard/hardware_keyboard_watcher.mm [delete] https://crrev.com/f6a6833d464b96fbc7cc27abe41e411487779ba2/ios/chrome/browser/ui/keyboard/hardware_keyboard_watcher_unittest.mm [modify] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/chrome/browser/ui/omnibox/location_bar_controller_impl.mm [modify] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/chrome/browser/ui/toolbar/BUILD.gn [delete] https://crrev.com/f6a6833d464b96fbc7cc27abe41e411487779ba2/ios/chrome/browser/ui/toolbar/keyboard_accessory_view.h [delete] https://crrev.com/f6a6833d464b96fbc7cc27abe41e411487779ba2/ios/chrome/browser/ui/toolbar/keyboard_accessory_view.mm [add] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/chrome/browser/ui/toolbar/keyboard_accessory_view_delegate.h [delete] https://crrev.com/f6a6833d464b96fbc7cc27abe41e411487779ba2/ios/chrome/browser/ui/toolbar/keyboard_accessory_view_protocol.h [modify] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/chrome/browser/ui/toolbar/new_keyboard_accessory_view.h [modify] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/chrome/browser/ui/toolbar/new_keyboard_accessory_view.mm [modify] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm [modify] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/clean/chrome/browser/ui/omnibox/location_bar_mediator.mm [modify] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/shared/chrome/browser/ui/omnibox/location_bar_delegate.h
Comment 1 by mard...@chromium.org
, Jul 10 2017