New issue
Advanced search Search tips

Issue 740608 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug

Blocking:
issue 707031



Sign in to add a comment

Port ui/base and ui_base_unittests to Fuchsia

Project Member Reported by sergeyu@google.com, Jul 10 2017

Issue description

Port ui/base and ui_base_unittests to Fuchsia
 
Blocking: 707031
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd4afb519be21d64ff5c1fc41768f0ec60c6b329

commit cd4afb519be21d64ff5c1fc41768f0ec60c6b329
Author: Sergey Ulanov <sergeyu@google.com>
Date: Tue Jul 11 01:18:04 2017

Add dummy ui::Clipboard implementation for Fuchsia

Fuchsia SDK doesn't yet provide access to Clipboard, so this is just
a dummy implementation to make it possible to compile ui/base

Bug: 740608
Change-Id: I3add17aad177787d2c7ee0f639ac9fc08286a54d
Reviewed-on: https://chromium-review.googlesource.com/565220
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485483}
[modify] https://crrev.com/cd4afb519be21d64ff5c1fc41768f0ec60c6b329/ui/base/BUILD.gn
[modify] https://crrev.com/cd4afb519be21d64ff5c1fc41768f0ec60c6b329/ui/base/clipboard/clipboard.h
[add] https://crrev.com/cd4afb519be21d64ff5c1fc41768f0ec60c6b329/ui/base/clipboard/clipboard_fuchsia.cc
[add] https://crrev.com/cd4afb519be21d64ff5c1fc41768f0ec60c6b329/ui/base/clipboard/clipboard_fuchsia.h

Project Member

Comment 3 by sheriffbot@chromium.org, Jul 11 2017

Labels: Hotlist-Google
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64ca0b56b1e4be7c9fc15c9de3a14d83633174b1

commit 64ca0b56b1e4be7c9fc15c9de3a14d83633174b1
Author: Sergey Ulanov <sergeyu@google.com>
Date: Wed Jul 12 19:38:35 2017

Add resource_bundle_fuchsia.cc with stubs for Fuchsia

In https://chromium-review.googlesource.com/c/565220/ I added
the file to BUILD.gn but forgot to include this file.

Bug: 740608
Change-Id: I4d3dad3ef2e6d61b2357f43906d601a3b1ce7f39
Reviewed-on: https://chromium-review.googlesource.com/568599
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486060}
[add] https://crrev.com/64ca0b56b1e4be7c9fc15c9de3a14d83633174b1/ui/base/resource/resource_bundle_fuchsia.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbd2fea96d75b3d05a71a8dcb6baa06f03baae43

commit fbd2fea96d75b3d05a71a8dcb6baa06f03baae43
Author: Sergey Ulanov <sergeyu@google.com>
Date: Fri Jul 14 01:01:38 2017

Build gl_unittests and ui_base_unittests on Fuchsia

gl_unittests and ui_base_unittests should compile on Fuchsia now

Bug: 740608
Change-Id: Ie2a15c3ed42578a063f2f6e349b61902b9551966
Reviewed-on: https://chromium-review.googlesource.com/566993
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486568}
[modify] https://crrev.com/fbd2fea96d75b3d05a71a8dcb6baa06f03baae43/BUILD.gn
[modify] https://crrev.com/fbd2fea96d75b3d05a71a8dcb6baa06f03baae43/testing/buildbot/chromium.fyi.json

Comment 6 by w...@chromium.org, Jul 15 2017

Components: Internals>PlatformIntegration
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a3b0613ab242aad2c002709c4673b204539fdbb

commit 0a3b0613ab242aad2c002709c4673b204539fdbb
Author: Sergey Ulanov <sergeyu@google.com>
Date: Wed Jul 19 04:35:59 2017

Enable ui_base_unittests and skia_unittests on Fuchsia

skia_unittests pass. ui_base_unittests need a filter.

Bug: 740608
Change-Id: I2e9bffb524d64fe0005789e612dcb0e0c7eedf5d
Reviewed-on: https://chromium-review.googlesource.com/575120
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487748}
[modify] https://crrev.com/0a3b0613ab242aad2c002709c4673b204539fdbb/testing/buildbot/chromium.fyi.json
[add] https://crrev.com/0a3b0613ab242aad2c002709c4673b204539fdbb/testing/buildbot/filters/fuchsia.ui_base_unittests.filter
[modify] https://crrev.com/0a3b0613ab242aad2c002709c4673b204539fdbb/testing/buildbot/gn_isolate_map.pyl

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9be7f817fc8b54832ada61e3968d7eec81e8e5b

commit c9be7f817fc8b54832ada61e3968d7eec81e8e5b
Author: Sergey Ulanov <sergeyu@google.com>
Date: Wed Jul 19 21:58:41 2017

Fixes in ui/base for Fuchsia

Some low-hanging fruit in ui/base:
1. Updated BUILD.gn to add pak files to data_pack, so these files are
accessible in the test VM.
2. Implemented ResourceBundle methods that were missing.

Now all tests in ui_base_unittests pass except those that write test
resource and /tmp (these fails because mmap() is broken on tmpfs).

Bug: 740608
Change-Id: I7534c40eba38ffcf1e12673360863034f3a89864
Reviewed-on: https://chromium-review.googlesource.com/575123
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488005}
[modify] https://crrev.com/c9be7f817fc8b54832ada61e3968d7eec81e8e5b/testing/buildbot/filters/fuchsia.ui_base_unittests.filter
[modify] https://crrev.com/c9be7f817fc8b54832ada61e3968d7eec81e8e5b/ui/base/BUILD.gn
[modify] https://crrev.com/c9be7f817fc8b54832ada61e3968d7eec81e8e5b/ui/base/resource/resource_bundle_fuchsia.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fafcb28f65c13a063dde9b0b80de3542f7f14d9f

commit fafcb28f65c13a063dde9b0b80de3542f7f14d9f
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Thu Aug 10 05:33:11 2017

Re-enable ui_base_unittests that depend on tmpfs mmap().

Bug: 740608
Change-Id: Id87849b27183dc02eb4f42e00eacb332e3aece33
Reviewed-on: https://chromium-review.googlesource.com/609389
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493279}
[modify] https://crrev.com/fafcb28f65c13a063dde9b0b80de3542f7f14d9f/testing/buildbot/filters/fuchsia.ui_base_unittests.filter

Sign in to add a comment