New issue
Advanced search Search tips

Issue 740596 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature
Proj-Servicification

Blocking:
issue 611935



Sign in to add a comment

[mojo-blobs] Stop transporting bytes for a blob if no more references to the blob exist

Project Member Reported by mek@chromium.org, Jul 10 2017

Issue description

In the current implementation BlobRegistryImpl will keep transporting bytes until it has received all bytes for a blob, and only then check if there still are references around to the blob. It would be nice to cancel building the blob as soon as the last reference to the blob goes away.
 

Comment 1 Deleted

Comment 2 by mek@chromium.org, Sep 29 2017

Labels: -merge-merged-3202
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df31d16831ae53eafaa85c5d7a7dff584fb05292

commit df31d16831ae53eafaa85c5d7a7dff584fb05292
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Thu Nov 02 18:44:41 2017

Fix crash if blob stops existing before transport begins.

If the last reference to a blob disappears before transport of the blob
begins just skip transporting data completely.

Bug:  740596 , 779495
Change-Id: I9408cd710c377c5fd45818eddcede3fb0e8898a8
Reviewed-on: https://chromium-review.googlesource.com/751106
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513564}
[modify] https://crrev.com/df31d16831ae53eafaa85c5d7a7dff584fb05292/storage/browser/blob/blob_registry_impl.cc
[modify] https://crrev.com/df31d16831ae53eafaa85c5d7a7dff584fb05292/storage/browser/blob/blob_registry_impl_unittest.cc

Comment 4 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 5 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Comment 6 by laforge@google.com, Nov 8 2017

Components: Internals>Services>Storage
Setting Internals>Services>Storage to all children of issue 611935
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa73af7e943b64af99d5619000ec529ff7727bad

commit fa73af7e943b64af99d5619000ec529ff7727bad
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Fri Mar 16 19:11:14 2018

[Blobs] Inform BlobRegistrImpl if a blob is destroyed while being build.

Which means that we abort transporting bytes for blobs we don't need.
Also fixes a memory leak if blob is dereferenced while allocating quota.

Bug:  740596 
Change-Id: I03a32b920f4e213adf59b54745c2d5fe071b3132
Reviewed-on: https://chromium-review.googlesource.com/965243
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543773}
[modify] https://crrev.com/fa73af7e943b64af99d5619000ec529ff7727bad/storage/browser/blob/blob_entry.cc
[modify] https://crrev.com/fa73af7e943b64af99d5619000ec529ff7727bad/storage/browser/blob/blob_entry.h
[modify] https://crrev.com/fa73af7e943b64af99d5619000ec529ff7727bad/storage/browser/blob/blob_registry_impl.cc
[modify] https://crrev.com/fa73af7e943b64af99d5619000ec529ff7727bad/storage/browser/blob/blob_registry_impl.h
[modify] https://crrev.com/fa73af7e943b64af99d5619000ec529ff7727bad/storage/browser/blob/blob_registry_impl_unittest.cc
[modify] https://crrev.com/fa73af7e943b64af99d5619000ec529ff7727bad/storage/browser/blob/blob_storage_context.cc
[modify] https://crrev.com/fa73af7e943b64af99d5619000ec529ff7727bad/storage/browser/blob/blob_storage_context.h

Comment 8 by mek@chromium.org, Mar 16 2018

Status: Fixed (was: Available)

Sign in to add a comment