Issue metadata
Sign in to add a comment
|
[mojo-blobs] Stop transporting bytes for a blob if no more references to the blob exist |
||||||||||||||||||||||
Issue descriptionIn the current implementation BlobRegistryImpl will keep transporting bytes until it has received all bytes for a blob, and only then check if there still are references around to the blob. It would be nice to cancel building the blob as soon as the last reference to the blob goes away.
,
Sep 29 2017
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df31d16831ae53eafaa85c5d7a7dff584fb05292 commit df31d16831ae53eafaa85c5d7a7dff584fb05292 Author: Marijn Kruisselbrink <mek@chromium.org> Date: Thu Nov 02 18:44:41 2017 Fix crash if blob stops existing before transport begins. If the last reference to a blob disappears before transport of the blob begins just skip transporting data completely. Bug: 740596 , 779495 Change-Id: I9408cd710c377c5fd45818eddcede3fb0e8898a8 Reviewed-on: https://chromium-review.googlesource.com/751106 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#513564} [modify] https://crrev.com/df31d16831ae53eafaa85c5d7a7dff584fb05292/storage/browser/blob/blob_registry_impl.cc [modify] https://crrev.com/df31d16831ae53eafaa85c5d7a7dff584fb05292/storage/browser/blob/blob_registry_impl_unittest.cc
,
Nov 7 2017
,
Nov 7 2017
Apologies, applied the wrong component in bulk.
,
Nov 8 2017
Setting Internals>Services>Storage to all children of issue 611935
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa73af7e943b64af99d5619000ec529ff7727bad commit fa73af7e943b64af99d5619000ec529ff7727bad Author: Marijn Kruisselbrink <mek@chromium.org> Date: Fri Mar 16 19:11:14 2018 [Blobs] Inform BlobRegistrImpl if a blob is destroyed while being build. Which means that we abort transporting bytes for blobs we don't need. Also fixes a memory leak if blob is dereferenced while allocating quota. Bug: 740596 Change-Id: I03a32b920f4e213adf59b54745c2d5fe071b3132 Reviewed-on: https://chromium-review.googlesource.com/965243 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#543773} [modify] https://crrev.com/fa73af7e943b64af99d5619000ec529ff7727bad/storage/browser/blob/blob_entry.cc [modify] https://crrev.com/fa73af7e943b64af99d5619000ec529ff7727bad/storage/browser/blob/blob_entry.h [modify] https://crrev.com/fa73af7e943b64af99d5619000ec529ff7727bad/storage/browser/blob/blob_registry_impl.cc [modify] https://crrev.com/fa73af7e943b64af99d5619000ec529ff7727bad/storage/browser/blob/blob_registry_impl.h [modify] https://crrev.com/fa73af7e943b64af99d5619000ec529ff7727bad/storage/browser/blob/blob_registry_impl_unittest.cc [modify] https://crrev.com/fa73af7e943b64af99d5619000ec529ff7727bad/storage/browser/blob/blob_storage_context.cc [modify] https://crrev.com/fa73af7e943b64af99d5619000ec529ff7727bad/storage/browser/blob/blob_storage_context.h
,
Mar 16 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 Deleted