New issue
Advanced search Search tips

Issue 740595 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task
Proj-Servicification

Blocking:
issue 611935



Sign in to add a comment

[mojo-blobs] Improve efficiency of BlobBytesProvider::RequestAsFile

Project Member Reported by mek@chromium.org, Jul 10 2017

Issue description

Currently this method linearly scans all data chunks to find the ones to write to the file; this could be fairly simply improved to a binary search by keeping track of the offsets where each chunk starts.
 

Comment 1 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 2 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Comment 3 by laforge@google.com, Nov 8 2017

Components: Internals>Services>Storage
Setting Internals>Services>Storage to all children of issue 611935
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b634a3a13398e24cf385f681842e6cf9e895b593

commit b634a3a13398e24cf385f681842e6cf9e895b593
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Fri Mar 16 17:11:15 2018

[Blobs] Improve efficiency of BlobBytesProvider::RequestAsFile.

Change linear search to binary search by keeping track of offsets of
individual blocks of data.

Bug:  740595 
Change-Id: Ibdb2ebdbf91b6e9c6bda7c04c4ab5f56fec7c876
Reviewed-on: https://chromium-review.googlesource.com/964914
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543737}
[modify] https://crrev.com/b634a3a13398e24cf385f681842e6cf9e895b593/third_party/WebKit/Source/platform/blob/BlobBytesProvider.cpp
[modify] https://crrev.com/b634a3a13398e24cf385f681842e6cf9e895b593/third_party/WebKit/Source/platform/blob/BlobBytesProvider.h

Comment 5 by mek@chromium.org, Mar 16 2018

Status: Fixed (was: Available)

Sign in to add a comment