New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 740594 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jul 2017
Cc:
█ jcgregorio@chromium.org
aga...@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

CQ fails to submit patch due to "Change xyz: Change xyz is work in progress" after being ready for review once

Project Member Reported by rmis...@google.com, Jul 10 2017 

In the CL https://skia-review.googlesource.com/c/22032/
it was "Set Ready For Review" in this comment: https://skia-review.googlesource.com/c/22032/#message-37182a0007cd053b40353ed5f905eb7983f701f7
it then failed the CQ, a new patch was uploaded, and then the CQ complained about: "Change 22032: Change 22032 is work in progress"

The change had to be remarked as "Set Ready for Review" in https://skia-review.googlesource.com/c/22032/#message-14aaeb599f097d11ff68a922fcd8937c671349c7

It seems that once a change is ready for review that setting should not go away. At which point does the setting go away and is this an intentional feature or a bug?

Comment 1 by aga...@chromium.org, Jul 10 2017

Status: Fixed (was: Untriaged)
The person uploading this change has an old depot_tools. Two weeks ago, there was a 4-hour period where git-cl-upload would set WIP on your change *every* time you uploaded a new patchset. That is no longer the case, though.

Comment 2 by rmis...@google.com, Jul 10 2017 

Thanks Aaron! Joe, can you try running "update_depot_tools".

Comment 3 by jcgrego...@google.com, Jul 10 2017 

Done, thanks!
►

Sign in to add a comment