New issue
Advanced search Search tips

Issue 740592 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task
Proj-Servicification

Blocking:
issue 611935
issue 776166



Sign in to add a comment

[mojo-blobs] Log histograms in BlobBytesProvider

Project Member Reported by mek@chromium.org, Jul 10 2017

Issue description

When transport fails for some reason in BlobBytesProvider we should log this to histograms. For example:
- when writing to the datapipe unexpectedly fails
- when seeking in files unexpectedly fails
- when writing to files unexpectedly fails
 

Comment 1 by mek@chromium.org, Oct 18 2017

Blocking: 776166
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a659a1b325746dee933e7d0590de1aa1ee25f633

commit a659a1b325746dee933e7d0590de1aa1ee25f633
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Mon Oct 23 22:18:08 2017

Log seek and write errors in BlobBytesProvider.

Log the same histograms BlobTransportController logs to in the IPC code
path to make it easy to compare error rates.

Bug:  740592 
Change-Id: Ic725383616dbac027af167439c12c810eccb31d4
Reviewed-on: https://chromium-review.googlesource.com/730862
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510939}
[modify] https://crrev.com/a659a1b325746dee933e7d0590de1aa1ee25f633/third_party/WebKit/Source/platform/blob/BlobBytesProvider.cpp

Comment 3 by mek@chromium.org, Oct 23 2017

Status: Fixed (was: Available)

Comment 4 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 5 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Comment 6 by laforge@google.com, Nov 8 2017

Components: Internals>Services>Storage
Setting Internals>Services>Storage to all children of issue 611935

Sign in to add a comment