Issue metadata
Sign in to add a comment
|
[mojo-blobs] Refactor BlobData/BlobDataHandle to create mojom::DataElements directly |
||||||||||||||||||||||
Issue descriptionCurrently BlobData creates BlobDataItem instances, which BlobDataHandle then converts to mojom::DataElement instances. Once the non-mojo codepath is gone it would be much cleaner to just create mojom::DataElement instances directly in BlobData.
,
Nov 7 2017
Apologies, applied the wrong component in bulk.
,
Nov 8 2017
Setting Internals>Services>Storage to all children of issue 611935
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d99dfc3a2c21bde7b116cbdc71b0075eda1e453 commit 9d99dfc3a2c21bde7b116cbdc71b0075eda1e453 Author: Marijn Kruisselbrink <mek@chromium.org> Date: Wed Jan 17 23:38:07 2018 Remove offset/length from BlobData::AppendData. The mojo code path (which is now the only code path) ignores offset and length for bytes data items, but fortunately this functionality isn't actually used so the simplest fix is to just remove this part of the API. Bug: 740588 Change-Id: I265735cf9d5f5b301ad703b62b24ea51031f0c98 Reviewed-on: https://chromium-review.googlesource.com/871179 Reviewed-by: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#529949} [modify] https://crrev.com/9d99dfc3a2c21bde7b116cbdc71b0075eda1e453/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp [modify] https://crrev.com/9d99dfc3a2c21bde7b116cbdc71b0075eda1e453/third_party/WebKit/Source/platform/blob/BlobData.cpp [modify] https://crrev.com/9d99dfc3a2c21bde7b116cbdc71b0075eda1e453/third_party/WebKit/Source/platform/blob/BlobData.h
,
Jan 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db1b4e28db01ef1f2fa9f138a426165f636f07cc commit db1b4e28db01ef1f2fa9f138a426165f636f07cc Author: Marijn Kruisselbrink <mek@chromium.org> Date: Thu Jan 18 21:42:40 2018 Eliminate blink::BlobDataItem. blink::BlobData now creates mojom::DataElement instances directly. TBR=kinuko@chromium.org Bug: 740588 Change-Id: Ied990349baec9ba89ad95b2253b35adcad1a6679 Reviewed-on: https://chromium-review.googlesource.com/872610 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#530280} [modify] https://crrev.com/db1b4e28db01ef1f2fa9f138a426165f636f07cc/third_party/WebKit/Source/core/fileapi/File.cpp [modify] https://crrev.com/db1b4e28db01ef1f2fa9f138a426165f636f07cc/third_party/WebKit/Source/platform/blob/BlobBytesProvider.cpp [modify] https://crrev.com/db1b4e28db01ef1f2fa9f138a426165f636f07cc/third_party/WebKit/Source/platform/blob/BlobBytesProvider.h [modify] https://crrev.com/db1b4e28db01ef1f2fa9f138a426165f636f07cc/third_party/WebKit/Source/platform/blob/BlobBytesProviderTest.cpp [modify] https://crrev.com/db1b4e28db01ef1f2fa9f138a426165f636f07cc/third_party/WebKit/Source/platform/blob/BlobData.cpp [modify] https://crrev.com/db1b4e28db01ef1f2fa9f138a426165f636f07cc/third_party/WebKit/Source/platform/blob/BlobData.h [modify] https://crrev.com/db1b4e28db01ef1f2fa9f138a426165f636f07cc/third_party/WebKit/Source/platform/blob/BlobDataTest.cpp [modify] https://crrev.com/db1b4e28db01ef1f2fa9f138a426165f636f07cc/third_party/WebKit/Source/platform/network/EncodedFormData.cpp
,
Jan 18 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by laforge@google.com
, Nov 7 2017