Blake, could you take a look?

Blake, any update on this issue?

I can't repro this on latest ToT .. still happening?

Yes, this is still happening. 

ok, we are getting really close to stable promotion for M60 
Is this something that is expected to be resolved this week? 

Blake, let me know if you need any help. Thanks.

Able to reproduce the issue on Chrome 61.0.3163.13/ CrOS 9765.7.0 - Caroline.

Not blocking initial M60 stable on this one. we can cherry pick a a merge if ready and safe to do for a subsequent stable refresh 

So, as it turns out, this has nothing to do with the restore bounds of windows getting corrupted, and everything to do with the KeyboardController missing SHOWN-to-HIDDEN state transition when you flip out of tablet mode.

When the keyboard opens, InputMethodBase gets notification of what the bounds are. When the keyboard closes, InputMethodBase also gets notification that the bounds should be cleared, but this notification occurs at the end of the HideAnimationFinished method. These bounds are used every time a window/tab gets focus and it tries to see if it needs to be moved into view. Since the keyboard hiding animation doesn't occur when you flip out of tablet mode, the bounds never get cleared and the InputMethodBase always thinks the keyboard bounds are still valid, even though the keyboard is no longer shown.

Good finding!
To elaborate, what's bad is KeyboardController::Reset has been called when the keyboard controller state is not HIDDEN.
I guess we should set the keyboard bound empty and call NotifyKeyboardBoundsChangingAndEnsrueCaretInWorkArea in Reset.

As far as I read some related code, KeyboardController::HideKeyboard() should be called when we flip out of tablet mode by a call chain like:
ash::VirtualKeyboardController::OnTabletModeEnded
 --> VirtualKeyboardController::SetKeyboardEnabled
 --> ash::Shell::DestroyKeyboard()
 --> RootWindowController::DeactivateKeyboard
 --> KeyboardController::HideKeyboard()

So, one possible solution I can think of is adding a method like |HideKeyboardImmediately| to KeyboardController and letting the method notify InputMethodBase immediately.
The change that oka@ described in comment # 10 should also work well.

 Issue 735551  has been merged into this issue.

Hi Blake, (just a quick FYI)

I patched your change (https://chromium-review.googlesource.com/c/602838) and confirmed that it fixes Issue 747086. We'll need to merge this back to M61 for the new applist as it's a high priority bugfix for the launch.

I'm keeping the other bug open rather than closing it as a duplicate since we'll add regression tests after your change lands.

Thanks!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae77b6cc958440822e99b3c038e1503f9240e180

commit ae77b6cc958440822e99b3c038e1503f9240e180
Author: Blake O'Hare <blakeo@chromium.org>
Date: Mon Aug 28 08:35:53 2017

Remove SHOWING and HIDING states from keyboard controller

This also changes the meaning of VirtualKeyboard.InitLatency.FirstLoad metric to record how long it takes for the JavaScript layout to load (even in the background). Now that pre-loading occurs, the previous timings did not provide insights anymore.

Bug:  740582 
Change-Id: I28a1ee6b8835261bd82a06f9547500d7d709b76d
Reviewed-on: https://chromium-review.googlesource.com/634723
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497714}
[modify] https://crrev.com/ae77b6cc958440822e99b3c038e1503f9240e180/chrome/browser/ui/ash/keyboard_controller_browsertest.cc
[modify] https://crrev.com/ae77b6cc958440822e99b3c038e1503f9240e180/ui/keyboard/BUILD.gn
[modify] https://crrev.com/ae77b6cc958440822e99b3c038e1503f9240e180/ui/keyboard/keyboard_controller.cc
[modify] https://crrev.com/ae77b6cc958440822e99b3c038e1503f9240e180/ui/keyboard/keyboard_controller.h
[modify] https://crrev.com/ae77b6cc958440822e99b3c038e1503f9240e180/ui/keyboard/keyboard_controller_unittest.cc

This bug requires manual review: We are only 6 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Approving merge to M61.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cefcf9b6afe2d89b17f8c3e1c1581b3326549e7

commit 5cefcf9b6afe2d89b17f8c3e1c1581b3326549e7
Author: yhanada <yhanada@chromium.org>
Date: Wed Aug 30 06:12:14 2017

Remove SHOWING and HIDING states from keyboard controller

This also changes the meaning of VirtualKeyboard.InitLatency.FirstLoad metric to record how long it takes for the JavaScript layout to load (even in the background). Now that pre-loading occurs, the previous timings did not provide insights anymore.

TBR=blakeo@chromium.org

(cherry picked from commit ae77b6cc958440822e99b3c038e1503f9240e180)

Bug:  740582 
Change-Id: I28a1ee6b8835261bd82a06f9547500d7d709b76d
Reviewed-on: https://chromium-review.googlesource.com/634723
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Keigo Oka <oka@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497714}
Reviewed-on: https://chromium-review.googlesource.com/642097
Cr-Commit-Position: refs/branch-heads/3163@{#993}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/5cefcf9b6afe2d89b17f8c3e1c1581b3326549e7/chrome/browser/ui/ash/keyboard_controller_browsertest.cc
[modify] https://crrev.com/5cefcf9b6afe2d89b17f8c3e1c1581b3326549e7/ui/keyboard/BUILD.gn
[modify] https://crrev.com/5cefcf9b6afe2d89b17f8c3e1c1581b3326549e7/ui/keyboard/keyboard_controller.cc
[modify] https://crrev.com/5cefcf9b6afe2d89b17f8c3e1c1581b3326549e7/ui/keyboard/keyboard_controller.h
[modify] https://crrev.com/5cefcf9b6afe2d89b17f8c3e1c1581b3326549e7/ui/keyboard/keyboard_controller_unittest.cc

Verified on M62 (9901.66.0, 62.0.3202.82 stable-channel)