First loading of ContentSuggestions image does not reload the cell |
||
Issue descriptionWhat steps will reproduce the problem? (1) Clear history (2) Open a NTP (potentially kill Chrome before) What is the expected result? The article should have an image What happens instead? The "no image" icon is shown.
,
Jul 12 2017
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e9a8febbec697cf6847291252e5fbf6be702334 commit 8e9a8febbec697cf6847291252e5fbf6be702334 Author: Sergio Collazos <sczs@chromium.org> Date: Wed Jul 12 18:41:21 2017 Revert "Disable prefetching on ContentSuggestions" This reverts commit 785f2e5f17b252a5c6787dcdc32171095b0b9d5f. Reason for revert: prefetchingEnabled is iOS 10+ so this is breaking tests on iOS 9 devices. Original change's description: > Disable prefetching on ContentSuggestions > > Prefetching allows the collection view to get cells configured by the > item before it is visible. The item will not reconfigure the cell for > this display. > If the CollectionViewController tries to reconfigure the items > associated with this cell in the moment between the prefetching and > the time the cell is visible, the reconfigure will do nothing. > > In ContentSuggestions this problem was encounter for the display of > the articles' images. > > Bug: 740572 > Change-Id: I99c1bd2a95159d22512494961b3fb1ad935ad998 > Reviewed-on: https://chromium-review.googlesource.com/567924 > Reviewed-by: Elodie Banel <lod@chromium.org> > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485933} TBR=lod@chromium.org,gambard@chromium.org Change-Id: I078f22735139d9e99de1348260509c692a281de6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 740572 Reviewed-on: https://chromium-review.googlesource.com/568403 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#486035} [modify] https://crrev.com/8e9a8febbec697cf6847291252e5fbf6be702334/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/755f0dd1940844042792972fe80755c95f6d8b29 commit 755f0dd1940844042792972fe80755c95f6d8b29 Author: gambard <gambard@chromium.org> Date: Thu Jul 13 08:36:39 2017 Reland "Disable prefetching on ContentSuggestions" Prefetching allows the collection view to get cells configured by the item before it is visible. The item will not reconfigure the cell for this display. If the CollectionViewController tries to reconfigure the items associated with this cell in the moment between the prefetching and the time the cell is visible, the reconfigure will do nothing. In ContentSuggestions this problem was encounter for the display of the articles' images. Bug: 740572 Change-Id: Ia9138b22a13796d6079f04113f95dab1f30b6fb5 Reviewed-on: https://chromium-review.googlesource.com/569162 Reviewed-by: Elodie Banel <lod@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#486320} [modify] https://crrev.com/755f0dd1940844042792972fe80755c95f6d8b29/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jul 12 2017